fix: Make error message more clear about where ordering must be enabled when publishing (#293)

kamalaboulhosn · web-flow · commit f54ed0284a9c · 2020-07-24T07:46:52.000-04:00
* feat: Add flow control support to publisher

* make suggested fixes

* chore: Remove note that ordering keys requires enablements.

* feat: Add support for server-side flow control

* Revert "chore: Remove note that ordering keys requires enablements."

This reverts commit 9c113c3e32c28cf0d1de8aad3409b5c509fb1ada.

* fix: Fix import order

* fix: Make error message more clear about where ordering must be enabled when publishing.
diff --git a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java
@@ -233,7 +233,9 @@ public ApiFuture<String> publish(PubsubMessage message) {
     final String orderingKey = message.getOrderingKey();
     Preconditions.checkState(
         orderingKey.isEmpty() || enableMessageOrdering,
-        "Cannot publish a message with an ordering key when message ordering is not enabled.");
+        "Cannot publish a message with an ordering key when message ordering is not enabled in the "
+            + "Publisher client. Please create a Publisher client with "
+            + "setEnableMessageOrdering(true) in the builder.");
 
     final OutstandingPublish outstandingPublish =
         new OutstandingPublish(messageTransform.apply(message));
