---

JesseLovelace · chingor13 · commit f455ac556d9e · 2019-05-22T13:51:31.000-07:00
yaml --- r: 33519 b: refs/heads/autosynth-os-login c: fff25ba h: refs/heads/master i: 33517: c6329e3 33515: 1e5bd29 33511: aee12dd 33503: 779d065
diff --git a/[refs] b/[refs]
@@ -134,7 +134,7 @@ refs/heads/autosynth-firestore: e79eeb26930dfae4439424ad2fda5874eeca54c8
 refs/heads/autosynth-iot: 044be280805a59e06d09658688c9ee474a9815ad
 refs/heads/autosynth-kms: d31449d6621a50fb16a4bef4f30f0f3051d27d7c
 refs/heads/autosynth-language: 6130869312f99a1e7d3aa0485759172a23333cc5
-refs/heads/autosynth-os-login: 720d90171cd515c21a21f9f8f17d638ff67ec09c
+refs/heads/autosynth-os-login: fff25ba885353dd4c9499d9084e4463291c72c9a
 refs/heads/autosynth-redis: 6bedce4d7c7c6ca6a22e83ad1780e08fdc565a9e
 refs/heads/autosynth-scheduler: 57f9fdb1e7de30c85f4ec7198931a07f50603e55
 refs/heads/autosynth-spanner: de02ca32edea133b68b51052e325359a3704b5d2
diff --git a/branches/autosynth-os-login/google-cloud-clients/google-cloud-core/src/main/java/com/google/cloud/Identity.java b/branches/autosynth-os-login/google-cloud-clients/google-cloud-core/src/main/java/com/google/cloud/Identity.java
@@ -255,7 +255,7 @@ public String strValue() {
    * policy identities to {@code Identity} objects.
    */
   public static Identity valueOf(String identityStr) {
-    String[] info = identityStr.split(":");
+    String[] info = identityStr.split(":", 2);
     Type type = Type.valueOf(CaseFormat.LOWER_CAMEL.to(CaseFormat.UPPER_UNDERSCORE, info[0]));
     if (info.length == 1) {
       return new Identity(type, null);
diff --git a/branches/autosynth-os-login/google-cloud-clients/google-cloud-core/src/test/java/com/google/cloud/IdentityTest.java b/branches/autosynth-os-login/google-cloud-clients/google-cloud-core/src/test/java/com/google/cloud/IdentityTest.java
@@ -141,16 +141,18 @@ public void testValueOfEmpty() {
     Identity.valueOf("");
   }
 
-  @Test(expected = IllegalArgumentException.class)
-  public void testValueOfThreePart() {
-    Identity.valueOf("a:b:c");
-  }
-
   @Test
   public void testUnrecognizedToString() {
     assertEquals("a:b", Identity.valueOf("a:b").strValue());
   }
 
+  @Test
+  public void testValueOfThreePart() {
+    Identity identity = Identity.valueOf("a:b:c");
+    assertEquals("A", identity.getType().name());
+    assertEquals("b:c", identity.getValue());
+  }
+
   private void compareIdentities(Identity expected, Identity actual) {
     assertEquals(expected, actual);
     assertEquals(expected.getType(), actual.getType());
