File system close declares it throws IOException (#1060)

jean-philippe-martin · mziccard · commit f322382c5c64 · 2016-06-20T08:31:34.000+02:00
diff --git a/gcloud-java-contrib/gcloud-java-nio/src/main/java/com/google/cloud/storage/contrib/nio/CloudStorageFileSystem.java b/gcloud-java-contrib/gcloud-java-nio/src/main/java/com/google/cloud/storage/contrib/nio/CloudStorageFileSystem.java
@@ -145,10 +145,12 @@ public CloudStoragePath getPath(String first, String... more) {
    * Does nothing.
    */
   @Override
-  public void close() {}
+  public void close() throws IOException {
+    // TODO(#809): Synchronously close all channels associated with this FileSystem instance.
+  }
 
   /**
-   * Returns {@code true}.
+   * Returns {@code true}, even if you previously called the {@link #close()} method.
    */
   @Override
   public boolean isOpen() {
diff --git a/gcloud-java-contrib/gcloud-java-nio/src/test/java/com/google/cloud/storage/contrib/nio/CloudStorageFileSystemProviderTest.java b/gcloud-java-contrib/gcloud-java-nio/src/test/java/com/google/cloud/storage/contrib/nio/CloudStorageFileSystemProviderTest.java
@@ -391,7 +391,7 @@ public void testExists_trailingSlash() {
   }
 
   @Test
-  public void testExists_trailingSlash_disablePseudoDirectories() {
+  public void testExists_trailingSlash_disablePseudoDirectories() throws IOException  {
     try (CloudStorageFileSystem fs = forBucket("military", usePseudoDirectories(false))) {
       assertThat(Files.exists(fs.getPath("fashion/"))).isFalse();
     }
@@ -547,7 +547,7 @@ public void testIsDirectory_trailingSlash_alwaysTrue() {
   }
 
   @Test
-  public void testIsDirectory_trailingSlash_pseudoDirectoriesDisabled_false() {
+  public void testIsDirectory_trailingSlash_pseudoDirectoriesDisabled_false() throws IOException  {
     try (CloudStorageFileSystem fs = forBucket("doodle", usePseudoDirectories(false))) {
       assertThat(Files.isDirectory(fs.getPath("fundir/"))).isFalse();
     }
diff --git a/gcloud-java-contrib/gcloud-java-nio/src/test/java/com/google/cloud/storage/contrib/nio/CloudStoragePathTest.java b/gcloud-java-contrib/gcloud-java-nio/src/test/java/com/google/cloud/storage/contrib/nio/CloudStoragePathTest.java

Original file line number	Diff line number	Diff line change
`@@ -391,7 +391,7 @@ public void testExists_trailingSlash() {`
`391`	`391`	`}`
`392`	`392`
`393`	`393`	`@Test`
`394`		`- public void testExists_trailingSlash_disablePseudoDirectories() {`
	`394`	`+ public void testExists_trailingSlash_disablePseudoDirectories() throws IOException {`
`395`	`395`	`try (CloudStorageFileSystem fs = forBucket("military", usePseudoDirectories(false))) {`
`396`	`396`	`assertThat(Files.exists(fs.getPath("fashion/"))).isFalse();`
`397`	`397`	`}`
`@@ -547,7 +547,7 @@ public void testIsDirectory_trailingSlash_alwaysTrue() {`
`547`	`547`	`}`
`548`	`548`
`549`	`549`	`@Test`
`550`		`- public void testIsDirectory_trailingSlash_pseudoDirectoriesDisabled_false() {`
	`550`	`+ public void testIsDirectory_trailingSlash_pseudoDirectoriesDisabled_false() throws IOException {`
`551`	`551`	`try (CloudStorageFileSystem fs = forBucket("doodle", usePseudoDirectories(false))) {`
`552`	`552`	`assertThat(Files.isDirectory(fs.getPath("fundir/"))).isFalse();`
`553`	`553`	`}`