minor rename and version bump

aozarov · aozarov · commit f09cae4bb057 · 2015-03-18T16:41:06.000-07:00
diff --git a/pom.xml b/pom.xml
@@ -4,7 +4,7 @@
   <groupId>com.google.gcloud</groupId>
   <artifactId>gcloud-java</artifactId>
   <packaging>jar</packaging>
-  <version>0.0.2</version>
+  <version>0.0.3</version>
   <name>GCloud Java</name>
   <url>https://github.com/GoogleCloudPlatform/gcloud-java</url>
   <description>
diff --git a/src/main/java/com/google/gcloud/ServiceOptions.java b/src/main/java/com/google/gcloud/ServiceOptions.java
@@ -75,7 +75,7 @@ public B httpTransport(HttpTransport httpTransport) {
       return self();
     }
 
-    public B authConfig(AuthCredentials authCredentials) {
+    public B authCredentials(AuthCredentials authCredentials) {
       this.authCredentials = authCredentials;
       return self();
     }
@@ -89,7 +89,7 @@ public B retryParams(RetryParams retryParams) {
   protected ServiceOptions(Builder<?> builder) {
     host = firstNonNull(builder.host, DEFAULT_HOST);
     httpTransport = firstNonNull(builder.httpTransport, defaultHttpTransport());
-    authCredentials = firstNonNull(builder.authCredentials, defaultAuthConfig());
+    authCredentials = firstNonNull(builder.authCredentials, defaultAuthCredentials());
     retryParams = builder.retryParams;
   }
 
@@ -111,7 +111,7 @@ private static HttpTransport defaultHttpTransport() {
     return new NetHttpTransport();
   }
 
-  public static AuthCredentials defaultAuthConfig() {
+  private static AuthCredentials defaultAuthCredentials() {
     // Consider App Engine. This will not be needed once issue #21 is fixed.
     if (appEngineAppId() != null) {
       try {
@@ -183,7 +183,7 @@ public HttpTransport httpTransport() {
     return httpTransport;
   }
 
-  public AuthCredentials authConfig() {
+  public AuthCredentials authCredentials() {
     return authCredentials;
   }
 
@@ -192,7 +192,7 @@ public RetryParams retryParams() {
   }
 
   public HttpRequestInitializer httpRequestInitializer() {
-    return authConfig().httpRequestInitializer(httpTransport, scopes());
+    return authCredentials().httpRequestInitializer(httpTransport, scopes());
   }
 
   public abstract Builder<?> toBuilder();
diff --git a/src/main/java/com/google/gcloud/datastore/BaseEntity.java b/src/main/java/com/google/gcloud/datastore/BaseEntity.java
@@ -127,7 +127,7 @@ public B remove(String name) {
       return self();
     }
 
-    public B set(String name, Value<?> value) {
+    public B set(String name, Value value) {
       properties.put(name, value);
       return self();
     }
diff --git a/src/test/java/com/google/gcloud/datastore/DatastoreServiceOptionsTest.java b/src/test/java/com/google/gcloud/datastore/DatastoreServiceOptionsTest.java
@@ -82,6 +82,6 @@ public void testToBuilder() throws Exception {
     assertEquals(original.host(), copy.host());
     assertEquals(original.force(), copy.force());
     assertEquals(original.retryParams(), copy.retryParams());
-    assertEquals(original.authConfig(), copy.authConfig());
+    assertEquals(original.authCredentials(), copy.authCredentials());
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ public B httpTransport(HttpTransport httpTransport) {`
`75`	`75`	`return self();`
`76`	`76`	`}`
`77`	`77`
`78`		`- public B authConfig(AuthCredentials authCredentials) {`
	`78`	`+ public B authCredentials(AuthCredentials authCredentials) {`
`79`	`79`	`this.authCredentials = authCredentials;`
`80`	`80`	`return self();`
`81`	`81`	`}`
`@@ -89,7 +89,7 @@ public B retryParams(RetryParams retryParams) {`
`89`	`89`	`protected ServiceOptions(Builder<?> builder) {`
`90`	`90`	`host = firstNonNull(builder.host, DEFAULT_HOST);`
`91`	`91`	`httpTransport = firstNonNull(builder.httpTransport, defaultHttpTransport());`
`92`		`- authCredentials = firstNonNull(builder.authCredentials, defaultAuthConfig());`
	`92`	`+ authCredentials = firstNonNull(builder.authCredentials, defaultAuthCredentials());`
`93`	`93`	`retryParams = builder.retryParams;`
`94`	`94`	`}`
`95`	`95`
`@@ -111,7 +111,7 @@ private static HttpTransport defaultHttpTransport() {`
`111`	`111`	`return new NetHttpTransport();`
`112`	`112`	`}`
`113`	`113`
`114`		`- public static AuthCredentials defaultAuthConfig() {`
	`114`	`+ private static AuthCredentials defaultAuthCredentials() {`
`115`	`115`	`// Consider App Engine. This will not be needed once issue #21 is fixed.`
`116`	`116`	`if (appEngineAppId() != null) {`
`117`	`117`	`try {`
`@@ -183,7 +183,7 @@ public HttpTransport httpTransport() {`
`183`	`183`	`return httpTransport;`
`184`	`184`	`}`
`185`	`185`
`186`		`- public AuthCredentials authConfig() {`
	`186`	`+ public AuthCredentials authCredentials() {`
`187`	`187`	`return authCredentials;`
`188`	`188`	`}`
`189`	`189`
`@@ -192,7 +192,7 @@ public RetryParams retryParams() {`
`192`	`192`	`}`
`193`	`193`
`194`	`194`	`public HttpRequestInitializer httpRequestInitializer() {`
`195`		`- return authConfig().httpRequestInitializer(httpTransport, scopes());`
	`195`	`+ return authCredentials().httpRequestInitializer(httpTransport, scopes());`
`196`	`196`	`}`
`197`	`197`
`198`	`198`	`public abstract Builder<?> toBuilder();`
Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,7 @@ public B remove(String name) {`
`127`	`127`	`return self();`
`128`	`128`	`}`
`129`	`129`
`130`		`- public B set(String name, Value<?> value) {`
	`130`	`+ public B set(String name, Value value) {`
`131`	`131`	`properties.put(name, value);`
`132`	`132`	`return self();`
`133`	`133`	`}`
Original file line number	Diff line number	Diff line change
`@@ -82,6 +82,6 @@ public void testToBuilder() throws Exception {`
`82`	`82`	`assertEquals(original.host(), copy.host());`
`83`	`83`	`assertEquals(original.force(), copy.force());`
`84`	`84`	`assertEquals(original.retryParams(), copy.retryParams());`
`85`		`- assertEquals(original.authConfig(), copy.authConfig());`
	`85`	`+ assertEquals(original.authCredentials(), copy.authCredentials());`
`86`	`86`	`}`
`87`	`87`	`}`