Skip to content

Commit ef1c6f8

Browse files
yihanzhenpongad
authored andcommitted
---
yaml --- r: 9227 b: refs/heads/spanner-gapic-migration c: 5d86ace h: refs/heads/master i: 9225: 0f4c06f 9223: 4b8c938
1 parent f4bc221 commit ef1c6f8

3 files changed

Lines changed: 10 additions & 6 deletions

File tree

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ refs/tags/v0.35.0: c28951c5f4cc97a1be07900d19df6984115a4bd6
8181
refs/tags/v0.36.0: 6b75c61f73e6827b3ca379bd54f88f750290162f
8282
refs/tags/v0.37.0: db2e142f92601709fdd48db159776f905742e30f
8383
refs/heads/mrschmidt-sizefix: 627a3bfa30bb6f4f76af47b228c38b208dd921e0
84-
refs/heads/spanner-gapic-migration: 3d81a15fba329e873ca6c50068ad7554fd793f7d
84+
refs/heads/spanner-gapic-migration: 5d86aceace0ee9f32a590076aefd5232a4b5d838
8585
refs/tags/v0.38.0: c235ee4df5e1248e1769dae3f86a0d7ab7fd8301
8686
refs/tags/v0.39.0: ab231c9d22475242a43d6d9554aa4a3f736dab01
8787
refs/tags/v0.40.0: a1d5b05206cce7734365f1b910396a2c9d6605ec

branches/spanner-gapic-migration/google-cloud-datastore/pom.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,10 @@
4040
</exclusion>
4141
</exclusions>
4242
</dependency>
43+
<dependency>
44+
<groupId>io.grpc</groupId>
45+
<artifactId>grpc-core</artifactId>
46+
</dependency>
4347
<dependency>
4448
<groupId>${project.groupId}</groupId>
4549
<artifactId>google-cloud-core</artifactId>

branches/spanner-gapic-migration/google-cloud-datastore/src/main/java/com/google/cloud/datastore/GqlQuery.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
import com.google.common.primitives.Booleans;
2828
import com.google.common.primitives.Doubles;
2929
import com.google.common.primitives.Longs;
30-
30+
import io.grpc.Status;
3131
import java.io.Serializable;
3232
import java.util.ArrayList;
3333
import java.util.Arrays;
@@ -282,9 +282,9 @@ public Builder<V> setBinding(String name, Key... value) {
282282
* @param value a {@link FullEntity} object or a list of {@link FullEntity} objects that binds
283283
* to a given name
284284
*/
285+
@Deprecated
285286
public Builder<V> setBinding(String name, FullEntity<?>... value) {
286-
namedBindings.put(name, toBinding(EntityValue.MARSHALLER, Arrays.asList(value)));
287-
return this;
287+
throw new DatastoreException(Status.Code.UNIMPLEMENTED.value(), "Binding entities is not supported.", "UNIMPLEMENTED");
288288
}
289289

290290
/**
@@ -378,9 +378,9 @@ public Builder<V> addBinding(Key... value) {
378378
* @param value a {@link FullEntity} object or a list of {@link FullEntity} objects to be set as
379379
* a new positional binding
380380
*/
381+
@Deprecated
381382
public Builder<V> addBinding(FullEntity<?>... value) {
382-
positionalBindings.add(toBinding(EntityValue.MARSHALLER, Arrays.asList(value)));
383-
return this;
383+
throw new DatastoreException(Status.Code.UNIMPLEMENTED.value(), "Binding entities is not supported.", "UNIMPLEMENTED");
384384
}
385385

386386
/**

0 commit comments

Comments
 (0)