---

mziccard · web-flow · commit ed7b6850cd19 · 2016-08-09T12:59:59.000+02:00
yaml --- r: 7477 b: refs/heads/tswast-patch-1 c: e1309f0 h: refs/heads/master i: 7475: eca350c
diff --git a/[refs] b/[refs]
@@ -57,5 +57,5 @@ refs/tags/v0.18.0: 9d193c4c4b9d1c6f21515dd8e50836b9194ec9bb
 refs/tags/v0.19.0: e67b56e4d8dad5f9a7b38c9b2107c23c828f2ed5
 refs/tags/v0.20.0: 839f7fb7156535146aa1cb2c5aadd8d375d854e8
 refs/tags/v0.20.1: 370471f437f1f4f68a11e068df5cd6bf39edb1fa
-refs/heads/tswast-patch-1: 64115e4512e8a9bf0d465056d7fef2143b077523
+refs/heads/tswast-patch-1: e1309f0811e50095a382497a5093413521c91a9c
 refs/heads/pubsub-streaming-pull: 19262b752ee874eb2ca3b950eb2aef44d5a5267b
diff --git a/branches/tswast-patch-1/gcloud-java-compute/src/main/java/com/google/cloud/compute/DeprecationStatus.java b/branches/tswast-patch-1/gcloud-java-compute/src/main/java/com/google/cloud/compute/DeprecationStatus.java
@@ -96,8 +96,8 @@ public static final class Builder<T extends ResourceId> {
      *
      * @see <a href="http://www.ietf.org/rfc/rfc3339.txt">RFC3339</a>
      */
-    // todo(mziccard): remove this method if #732 is closed
-    public Builder<T> deleted(String deleted) {
+    // Wrongly-formatted timestamps were allowed, we must still support them (see #732 for details)
+    Builder<T> deleted(String deleted) {
       this.deleted = deleted;
       return this;
     }
@@ -108,8 +108,8 @@ public Builder<T> deleted(String deleted) {
      *
      * @see <a href="http://www.ietf.org/rfc/rfc3339.txt">RFC3339</a>
      */
-    // todo(mziccard): remove this method if #732 is closed
-    public Builder<T> deprecated(String deprecated) {
+    // Wrongly-formatted timestamps were allowed, we must still support them (see #732 for details)
+    Builder<T> deprecated(String deprecated) {
       this.deprecated = deprecated;
       return this;
     }
@@ -120,8 +120,8 @@ public Builder<T> deprecated(String deprecated) {
      *
      * @see <a href="http://www.ietf.org/rfc/rfc3339.txt">RFC3339</a>
      */
-    // todo(mziccard): remove this method if #732 is closed
-    public Builder<T> obsolete(String obsolete) {
+    // Wrongly-formatted timestamps were allowed, we must still support them (see #732 for details)
+    Builder<T> obsolete(String obsolete) {
       this.obsolete = obsolete;
       return this;
     }
@@ -193,7 +193,7 @@ public DeprecationStatus<T> build() {
    *
    * @see <a href="http://www.ietf.org/rfc/rfc3339.txt">RFC3339</a>
    */
-  // todo(mziccard): remove this method if #732 is closed
+  // Wrongly-formatted timestamps were allowed, we must still support them (see #732 for details)
   public String deleted() {
     return deleted;
   }
@@ -205,7 +205,7 @@ public String deleted() {
    *
    * @see <a href="http://www.ietf.org/rfc/rfc3339.txt">RFC3339</a>
    */
-  // todo(mziccard): remove this method if #732 is closed
+  // Wrongly-formatted timestamps were allowed, we must still support them (see #732 for details)
   public String deprecated() {
     return deprecated;
   }
@@ -217,7 +217,7 @@ public String deprecated() {
    *
    * @see <a href="http://www.ietf.org/rfc/rfc3339.txt">RFC3339</a>
    */
-  // todo(mziccard): remove this method if #732 is closed
+  // Wrongly-formatted timestamps were allowed, we must still support them (see #732 for details)
   public String obsolete() {
     return obsolete;
   }

Original file line number	Diff line number	Diff line change
`@@ -96,8 +96,8 @@ public static final class Builder<T extends ResourceId> {`
`96`	`96`	`*`
`97`	`97`	`* @see <a href="http://www.ietf.org/rfc/rfc3339.txt">RFC3339</a>`
`98`	`98`	`*/`
`99`		`- // todo(mziccard): remove this method if #732 is closed`
`100`		`- public Builder<T> deleted(String deleted) {`
	`99`	`+ // Wrongly-formatted timestamps were allowed, we must still support them (see #732 for details)`
	`100`	`+ Builder<T> deleted(String deleted) {`
`101`	`101`	`this.deleted = deleted;`
`102`	`102`	`return this;`
`103`	`103`	`}`
`@@ -108,8 +108,8 @@ public Builder<T> deleted(String deleted) {`
`108`	`108`	`*`
`109`	`109`	`* @see <a href="http://www.ietf.org/rfc/rfc3339.txt">RFC3339</a>`
`110`	`110`	`*/`
`111`		`- // todo(mziccard): remove this method if #732 is closed`
`112`		`- public Builder<T> deprecated(String deprecated) {`
	`111`	`+ // Wrongly-formatted timestamps were allowed, we must still support them (see #732 for details)`
	`112`	`+ Builder<T> deprecated(String deprecated) {`
`113`	`113`	`this.deprecated = deprecated;`
`114`	`114`	`return this;`
`115`	`115`	`}`
`@@ -120,8 +120,8 @@ public Builder<T> deprecated(String deprecated) {`
`120`	`120`	`*`
`121`	`121`	`* @see <a href="http://www.ietf.org/rfc/rfc3339.txt">RFC3339</a>`
`122`	`122`	`*/`
`123`		`- // todo(mziccard): remove this method if #732 is closed`
`124`		`- public Builder<T> obsolete(String obsolete) {`
	`123`	`+ // Wrongly-formatted timestamps were allowed, we must still support them (see #732 for details)`
	`124`	`+ Builder<T> obsolete(String obsolete) {`
`125`	`125`	`this.obsolete = obsolete;`
`126`	`126`	`return this;`
`127`	`127`	`}`
`@@ -193,7 +193,7 @@ public DeprecationStatus<T> build() {`
`193`	`193`	`*`
`194`	`194`	`* @see <a href="http://www.ietf.org/rfc/rfc3339.txt">RFC3339</a>`
`195`	`195`	`*/`
`196`		`- // todo(mziccard): remove this method if #732 is closed`
	`196`	`+ // Wrongly-formatted timestamps were allowed, we must still support them (see #732 for details)`
`197`	`197`	`public String deleted() {`
`198`	`198`	`return deleted;`
`199`	`199`	`}`
`@@ -205,7 +205,7 @@ public String deleted() {`
`205`	`205`	`*`
`206`	`206`	`* @see <a href="http://www.ietf.org/rfc/rfc3339.txt">RFC3339</a>`
`207`	`207`	`*/`
`208`		`- // todo(mziccard): remove this method if #732 is closed`
	`208`	`+ // Wrongly-formatted timestamps were allowed, we must still support them (see #732 for details)`
`209`	`209`	`public String deprecated() {`
`210`	`210`	`return deprecated;`
`211`	`211`	`}`
`@@ -217,7 +217,7 @@ public String deprecated() {`
`217`	`217`	`*`
`218`	`218`	`* @see <a href="http://www.ietf.org/rfc/rfc3339.txt">RFC3339</a>`
`219`	`219`	`*/`
`220`		`- // todo(mziccard): remove this method if #732 is closed`
	`220`	`+ // Wrongly-formatted timestamps were allowed, we must still support them (see #732 for details)`
`221`	`221`	`public String obsolete() {`
`222`	`222`	`return obsolete;`
`223`	`223`	`}`