---

sduskis · web-flow · commit eb7850e6249b · 2019-04-16T10:59:27.000-04:00
yaml --- r: 34399 b: refs/heads/autosynth-tasks c: e5e7a21 h: refs/heads/master i: 34397: 902e163 34395: 463eda8 34391: 7cba680 34383: 9e8cca5 34367: 4daa891
diff --git a/[refs] b/[refs]
@@ -139,7 +139,7 @@ refs/heads/autosynth-redis: 2b698ebe7faaa0b93246576a88941682e0888e57
 refs/heads/autosynth-scheduler: a3de6480746d1cd586ca8b9d75c55a636f371539
 refs/heads/autosynth-spanner: d963fe4368e79cf6abae5d511785e8ced8ac57f4
 refs/heads/autosynth-speech: c563dcd420cce0a37c39b1b9c24be1b9ba604dc7
-refs/heads/autosynth-tasks: 3c8c8d6104f8b914a7899fbd3258bd7534932664
+refs/heads/autosynth-tasks: e5e7a21bdc829ae207af71388e1a37fe286f2cc1
 refs/heads/autosynth-texttospeech: 2c442fe0b7f089fbab266edfe4dd83c532e82dd0
 refs/heads/autosynth-trace: c94eef6e4d9c6fd24888216e28ca7271959c1cf0
 refs/heads/autosynth-websecurityscanner: fa561b356aabcd92d415ae8dc88fd8d87dbc5b23
diff --git a/branches/autosynth-tasks/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/MessageDispatcher.java b/branches/autosynth-tasks/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/MessageDispatcher.java
@@ -376,8 +376,7 @@ public void run() {
   /** Compute the ideal deadline, set subsequent modacks to this deadline, and return it. */
   @InternalApi
   int computeDeadlineSeconds() {
-    long secLong = ackLatencyDistribution.getNthPercentile(PERCENTILE_FOR_ACK_DEADLINE_UPDATES);
-    int sec = Ints.saturatedCast(secLong);
+    int sec = ackLatencyDistribution.getPercentile(PERCENTILE_FOR_ACK_DEADLINE_UPDATES);
 
     // Use Ints.constrainToRange when we get guava 21.
     if (sec < Subscriber.MIN_ACK_DEADLINE_SECONDS) {
diff --git a/branches/autosynth-tasks/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java b/branches/autosynth-tasks/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java
@@ -16,6 +16,8 @@
 
 package com.google.cloud.pubsub.v1;
 
+import static com.google.common.util.concurrent.MoreExecutors.directExecutor;
+
 import com.google.api.core.ApiFunction;
 import com.google.api.core.ApiFuture;
 import com.google.api.core.ApiFutureCallback;
@@ -357,7 +359,8 @@ public void onFailure(Throwable t) {
               messagesWaiter.incrementPendingMessages(-outstandingBatch.size());
             }
           }
-        });
+        },
+        directExecutor());
   }
 
   private static final class OutstandingBatch {
diff --git a/branches/autosynth-tasks/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/StreamingSubscriberConnection.java b/branches/autosynth-tasks/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/StreamingSubscriberConnection.java
@@ -16,6 +16,8 @@
 
 package com.google.cloud.pubsub.v1;
 
+import static com.google.common.util.concurrent.MoreExecutors.directExecutor;
+
 import com.google.api.core.AbstractApiService;
 import com.google.api.core.ApiClock;
 import com.google.api.core.ApiFuture;
@@ -291,7 +293,7 @@ public void onFailure(Throwable t) {
                         .addAllAckIds(idChunk)
                         .setAckDeadlineSeconds(modack.deadlineExtensionSeconds)
                         .build());
-        ApiFutures.addCallback(future, loggingCallback);
+        ApiFutures.addCallback(future, loggingCallback, directExecutor());
       }
     }
 
@@ -303,7 +305,7 @@ public void onFailure(Throwable t) {
                       .setSubscription(subscription)
                       .addAllAckIds(idChunk)
                       .build());
-      ApiFutures.addCallback(future, loggingCallback);
+      ApiFutures.addCallback(future, loggingCallback, directExecutor());
     }
   }
 }
diff --git a/branches/autosynth-tasks/google-cloud-clients/google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/it/ITPubSubTest.java b/branches/autosynth-tasks/google-cloud-clients/google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/it/ITPubSubTest.java
@@ -42,8 +42,8 @@
 import java.util.concurrent.BlockingQueue;
 import java.util.concurrent.LinkedBlockingQueue;
 import java.util.concurrent.TimeUnit;
-import junit.framework.Assert;
 import org.junit.AfterClass;
+import org.junit.Assert;
 import org.junit.BeforeClass;
 import org.junit.Rule;
 import org.junit.Test;

Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,8 @@`
`16`	`16`
`17`	`17`	`package com.google.cloud.pubsub.v1;`
`18`	`18`
	`19`	`+import static com.google.common.util.concurrent.MoreExecutors.directExecutor;`
	`20`	`+`
`19`	`21`	`import com.google.api.core.ApiFunction;`
`20`	`22`	`import com.google.api.core.ApiFuture;`
`21`	`23`	`import com.google.api.core.ApiFutureCallback;`
`@@ -357,7 +359,8 @@ public void onFailure(Throwable t) {`
`357`	`359`	`messagesWaiter.incrementPendingMessages(-outstandingBatch.size());`
`358`	`360`	`}`
`359`	`361`	`}`
`360`		`- });`
	`362`	`+ },`
	`363`	`+ directExecutor());`
`361`	`364`	`}`
`362`	`365`
`363`	`366`	`private static final class OutstandingBatch {`