---

chingor13 · web-flow · commit eb50e40ce7aa · 2019-01-07T11:05:08.000-08:00
yaml --- r: 17099 b: refs/heads/autosynth-scheduler c: f28bbcc h: refs/heads/master i: 17097: 2f5feb8 17095: 4bec557
diff --git a/[refs] b/[refs]
@@ -138,7 +138,7 @@ refs/heads/autosynth-kms: 4fff8f3cf6c830f7706ac4ef272f036bb87fbaf8
 refs/heads/autosynth-language: 6262e2eb76944f01972c887b3e684aaf65ec999a
 refs/heads/autosynth-os-login: a88a337797996a205873040a63abe1d3116f5789
 refs/heads/autosynth-redis: 0cdb2e47359d51b73763bcea8af3de62aa99119b
-refs/heads/autosynth-scheduler: 978f3b7aa6a1bf74641af684aa4aaff4468178e3
+refs/heads/autosynth-scheduler: f28bbcce35c6d178e36cd50d3e4daf4f81717919
 refs/heads/autosynth-securitycenter: 8e95447ccb176c3648880ee0cb926cd1f4065156
 refs/heads/autosynth-spanner: 563dc6c78c6a2579b681f441f0a9b59005212394
 refs/heads/autosynth-speech: 878243784f42771467d7cf52bd59e4a6a7950ee9
diff --git a/branches/autosynth-scheduler/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/AckReplyConsumer.java b/branches/autosynth-scheduler/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/AckReplyConsumer.java
@@ -29,6 +29,4 @@ public interface AckReplyConsumer {
    * message.
    */
   void nack();
-
-  void abandon();
 }
diff --git a/branches/autosynth-scheduler/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/MessageDispatcher.java b/branches/autosynth-scheduler/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/MessageDispatcher.java
@@ -133,7 +133,6 @@ private class AckHandler implements ApiFutureCallback<AckReply> {
     private final int outstandingBytes;
     private final long receivedTimeMillis;
     private final Instant totalExpiration;
-    private boolean extending = true;
 
     AckHandler(String ackId, int outstandingBytes, Instant totalExpiration) {
       this.ackId = ackId;
@@ -152,7 +151,6 @@ private void forget() {
          */
         return;
       }
-      extending = false;
       flowController.release(1, outstandingBytes);
       messagesWaiter.incrementPendingMessages(-1);
       processOutstandingBatches();
@@ -419,11 +417,6 @@ public void ack() {
             public void nack() {
               response.set(AckReply.NACK);
             }
-
-            @Override
-            public void abandon() {
-              ackHandler.forget();
-            }
           };
       ApiFutures.addCallback(response, ackHandler, MoreExecutors.directExecutor());
       executor.execute(
@@ -478,9 +471,6 @@ void extendDeadlines() {
     Instant extendTo = now.plusSeconds(extendSeconds);
 
     for (Map.Entry<String, AckHandler> entry : pendingMessages.entrySet()) {
-      if (!entry.getValue().extending) {
-        continue;
-      }
       String ackId = entry.getKey();
       Instant totalExpiration = entry.getValue().totalExpiration;
       if (totalExpiration.isAfter(extendTo)) {
diff --git a/branches/autosynth-scheduler/google-cloud-clients/google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/v1/MessageDispatcherTest.java b/branches/autosynth-scheduler/google-cloud-clients/google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/v1/MessageDispatcherTest.java
@@ -148,14 +148,6 @@ public void testNack() throws Exception {
     assertThat(sentModAcks).contains(ModAckItem.of(TEST_MESSAGE.getAckId(), 0));
   }
 
-  @Test
-  public void testAbandon() throws Exception {
-    dispatcher.processReceivedMessages(Collections.singletonList(TEST_MESSAGE), NOOP_RUNNABLE);
-    consumers.take().abandon();
-    dispatcher.extendDeadlines();
-    assertThat(sentModAcks).doesNotContain(TEST_MESSAGE.getAckId());
-  }
-
   @Test
   public void testExtension() throws Exception {
     dispatcher.processReceivedMessages(Collections.singletonList(TEST_MESSAGE), NOOP_RUNNABLE);

Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,4 @@ public interface AckReplyConsumer {`
`29`	`29`	`* message.`
`30`	`30`	`*/`
`31`	`31`	`void nack();`
`32`		`-`
`33`		`- void abandon();`
`34`	`32`	`}`