Skip to content

Commit e9a951a

Browse files
committed
---
yaml --- r: 26847 b: refs/heads/v4support c: 8958a7d h: refs/heads/master i: 26845: 0b25b6c 26843: 30d29e1 26839: c1a11cf 26831: 15540c0 26815: a8bc419
1 parent 52fd247 commit e9a951a

3 files changed

Lines changed: 3 additions & 12 deletions

File tree

  • branches/v4support
    • google-cloud-clients/google-cloud-storage/src/main/java/com/google/cloud/storage
    • google-cloud-examples/src/test/java/com/google/cloud/examples/storage/snippets

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ refs/heads/igorbernstein2-patch-1: f62464ee14df1e44a3b173cdc3976563d1b3078b
176176
refs/heads/mrschmidt-collectiongroup: a6d948bf3731a7e1ce1fcd3db8ab733a3c9b17de
177177
refs/heads/release-google-cloud-java-v0.83.0: 4b55ec1b81b3886ede61ae868391a3cdf7eed90e
178178
refs/heads/release-google-cloud-java-v0.83.1-SNAPSHOT: 8d6db7ee534d12b1df38d8cf314871df76f87577
179-
refs/heads/v4support: 7a836e44a4bb0ea6cc6f240bf23f74250c6fd38b
179+
refs/heads/v4support: 8958a7d8b70e455146413fd1d90c86d4039b9abb
180180
refs/tags/v0.82.0: 7b9807d5d0a400c757b8905fee768be4c85eba25
181181
refs/tags/v0.83.0: 370ec5a1131a86b36db8efce4f1a943607de8a60
182182
refs/tags/v0.84.0: 71e85198495a39f4524afa2669434b5075c17c3d

branches/v4support/google-cloud-clients/google-cloud-storage/src/main/java/com/google/cloud/storage/StorageImpl.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,6 @@
8282

8383
final class StorageImpl extends BaseService<StorageOptions> implements Storage {
8484

85-
private static final Logger log = Logger.getLogger(StorageImpl.class.getName());
86-
8785
private static final byte[] EMPTY_BYTE_ARRAY = {};
8886
private static final String EMPTY_BYTE_ARRAY_MD5 = "1B2M2Y8AsgTpgAmY7PhCfg==";
8987
private static final String EMPTY_BYTE_ARRAY_CRC32C = "AAAAAA==";
@@ -677,13 +675,6 @@ public URL signUrl(BlobInfo blobInfo, long duration, TimeUnit unit, SignUrlOptio
677675
stBuilder.append("GoogleAccessId=").append(credentials.getAccount());
678676
stBuilder.append("&Expires=").append(expiration);
679677
stBuilder.append("&Signature=").append(signature);
680-
681-
log.warning(
682-
"You have generated a signed URL using the V2 signing implementation. This is currently "
683-
+ "the default, but in the future, this will default to V4. You may experience breaking changes "
684-
+ "if you use long expiration times with V4, since the maximum expiration time for V4 is 7 days. To "
685-
+ "opt-in to V4 signing, specify Storage.SignUrlOption.withV4Signature() as a parameter to "
686-
+ "the signUrl() method.");
687678
}
688679

689680
return new URL(stBuilder.toString());

branches/v4support/google-cloud-examples/src/test/java/com/google/cloud/examples/storage/snippets/ITStorageSnippets.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,10 @@
4444
import java.io.ByteArrayOutputStream;
4545
import java.io.IOException;
4646
import java.io.InputStream;
47-
import java.io.PrintStream;
4847
import java.io.OutputStream;
48+
import java.io.PrintStream;
4949
import java.net.URL;
5050
import java.net.URLConnection;
51-
import javax.net.ssl.HttpsURLConnection;
5251
import java.nio.file.Files;
5352
import java.nio.file.Paths;
5453
import java.util.Date;
@@ -60,6 +59,7 @@
6059
import java.util.concurrent.TimeUnit;
6160
import java.util.logging.Level;
6261
import java.util.logging.Logger;
62+
import javax.net.ssl.HttpsURLConnection;
6363
import org.junit.AfterClass;
6464
import org.junit.BeforeClass;
6565
import org.junit.Rule;

0 commit comments

Comments
 (0)