Updating hash()

schmidt-sebastian · schmidt-sebastian · commit e96c50a91e30 · 2018-06-07T14:21:07.000-07:00
diff --git a/google-cloud-clients/google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreOptions.java b/google-cloud-clients/google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreOptions.java
@@ -169,16 +169,6 @@ public Builder setCredentialsProvider(@Nonnull CredentialsProvider credentialsPr
       return this;
     }
 
-    /**
-     * Sets the database ID to use with this Firestore client.
-     *
-     * @param databaseId The Firestore database ID to use with this client.
-     */
-    public Builder setDatabaseId(@Nonnull String databaseId) {
-      this.databaseId = databaseId;
-      return this;
-    }
-
     /**
      * Enables the use of {@link com.google.cloud.Timestamp Timestamps} for timestamp fields in
      * {@link DocumentSnapshot DocumentSnapshots}.
@@ -206,6 +196,17 @@ public Builder setTimestampsInSnapshotsEnabled(boolean value) {
       return this;
     }
 
+    /**
+     * Sets the database ID to use with this Firestore client.
+     *
+     * @param databaseId The Firestore database ID to use with this client.
+     */
+    @Nonnull
+    public Builder setDatabaseId(@Nonnull String databaseId) {
+      this.databaseId = databaseId;
+      return this;
+    }
+
     @Override
     @Nonnull
     public FirestoreOptions build() {
@@ -218,9 +219,9 @@ protected FirestoreOptions(Builder builder) {
     super(FirestoreFactory.class, FirestoreRpcFactory.class, builder, new FirestoreDefaults());
 
     this.databaseId = builder.databaseId;
+    this.timestampsInSnapshotsEnabled = builder.timestampsInSnapshotsEnabled;
     this.channelProvider = builder.channelProvider;
     this.credentialsProvider = builder.credentialsProvider;
-    this.timestampsInSnapshotsEnabled = builder.timestampsInSnapshotsEnabled;
   }
 
   private static class FirestoreDefaults implements ServiceDefaults<Firestore, FirestoreOptions> {
@@ -317,12 +318,19 @@ public boolean equals(Object o) {
     FirestoreOptions that = (FirestoreOptions) o;
     return Objects.equals(databaseId, that.databaseId)
         && Objects.equals(channelProvider, that.channelProvider)
+        && Objects.equals(credentialsProvider, that.credentialsProvider)
+        && Objects.equals(timestampsInSnapshotsEnabled, that.timestampsInSnapshotsEnabled)
         && baseEquals(that);
   }
 
   @Override
   public int hashCode() {
-    return Objects.hash(databaseId, channelProvider, baseHashCode());
+    return Objects.hash(
+        databaseId,
+        channelProvider,
+        credentialsProvider,
+        timestampsInSnapshotsEnabled,
+        baseHashCode());
   }
 
   @Nonnull
