Skip to content

Commit e94d771

Browse files
abhinav-qlogicsduskis
abhinav-qlogic
authored and
sduskis
committed
---
yaml --- r: 32423 b: refs/heads/autosynth-errorreporting c: 2000afb h: refs/heads/master i: 32421: 955c516 32419: 2dc273f 32415: a37aaee
1 parent 3657e84 commit e94d771

4 files changed

Lines changed: 12 additions & 12 deletions

File tree

‎[refs]‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ refs/heads/autosynth-bigtable-admin: 6379a2bc712f2736c83de0e009b4d26da4fa82ca
129129
refs/heads/autosynth-containeranalysis: 18d210f81f17cf74864d0db2c29e834302f74f2a
130130
refs/heads/autosynth-datastore: f1efc3dc465174f41041acd56cf29badcec3e5bd
131131
refs/heads/autosynth-dialogflow: 73974cc32e5212aec0126472e0bc1442886fedaf
132-
refs/heads/autosynth-errorreporting: 28b211fe52ced1e256561eac518047a10676dde0
132+
refs/heads/autosynth-errorreporting: 2000afbd914a4f64653d7019b4b45867ca86d316
133133
refs/heads/autosynth-firestore: 983c75e4fb1076502c8cac73ef0538bdb10884f3
134134
refs/heads/autosynth-iot: 4025d1804241e74d54950a324dc4f667aeaad4b3
135135
refs/heads/autosynth-kms: 6b65b0f34c12d141031c7288cdc01e550212d0f6

‎branches/autosynth-errorreporting/google-cloud-clients/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/BigQueryImplTest.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -979,7 +979,7 @@ public void testDeleteTable() {
979979
EasyMock.expect(bigqueryRpcMock.deleteTable(PROJECT, DATASET, TABLE)).andReturn(true);
980980
EasyMock.replay(bigqueryRpcMock);
981981
bigquery = options.getService();
982-
assertTrue(bigquery.delete(DATASET, TABLE));
982+
assertTrue(bigquery.delete(TABLE_ID));
983983
}
984984

985985
@Test

‎branches/autosynth-errorreporting/google-cloud-clients/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/JobTest.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ public Iterable<FieldValueList> getValues() {
297297

298298
replay(status, bigquery, mockOptions);
299299
initializeJob(jobInfo);
300-
assertThat(job.waitFor(TEST_RETRY_OPTIONS)).isSameAs(completedJob);
300+
assertThat(job.waitFor(TEST_RETRY_OPTIONS)).isSameInstanceAs(completedJob);
301301
assertThat(job.getQueryResults().iterateAll()).isEmpty();
302302
verify(status, mockOptions);
303303
}
@@ -345,7 +345,7 @@ public void testWaitForAndGetQueryResultsEmptyWithSchema() throws InterruptedExc
345345

346346
replay(status, bigquery, mockOptions);
347347
initializeJob(jobInfo);
348-
assertThat(job.waitFor(TEST_RETRY_OPTIONS)).isSameAs(completedJob);
348+
assertThat(job.waitFor(TEST_RETRY_OPTIONS)).isSameInstanceAs(completedJob);
349349
assertThat(job.getQueryResults().getSchema())
350350
.isEqualTo(Schema.of(Field.of("field1", LegacySQLTypeName.BOOLEAN)));
351351
verify(status, mockOptions);
@@ -424,7 +424,7 @@ public Iterable<FieldValueList> getValues() {
424424

425425
replay(status, bigquery, mockOptions);
426426
initializeJob(jobInfo);
427-
assertThat(job.waitFor(TEST_RETRY_OPTIONS)).isSameAs(completedJob);
427+
assertThat(job.waitFor(TEST_RETRY_OPTIONS)).isSameInstanceAs(completedJob);
428428
assertThat(job.getQueryResults().iterateAll()).hasSize(0);
429429
verify(status, mockOptions);
430430
}

‎branches/autosynth-errorreporting/google-cloud-clients/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -676,7 +676,7 @@ public void testListPartitions() throws InterruptedException {
676676
List<String> partitions = bigquery.listPartitions(TableId.of(DATASET, tableName));
677677
assertEquals(1, partitions.size());
678678
} finally {
679-
bigquery.delete(DATASET, tableName);
679+
bigquery.delete(tableId);
680680
}
681681
}
682682

@@ -806,7 +806,7 @@ public void testUpdateNonExistingTable() {
806806

807807
@Test
808808
public void testDeleteNonExistingTable() {
809-
assertFalse(bigquery.delete(DATASET, "test_delete_non_existing_table"));
809+
assertFalse(bigquery.delete("test_delete_non_existing_table"));
810810
}
811811

812812
@Test
@@ -1280,7 +1280,7 @@ public void testCreateAndGetJob() throws InterruptedException, TimeoutException
12801280

12811281
assertNotNull(completedJob);
12821282
assertNull(completedJob.getStatus().getError());
1283-
assertTrue(bigquery.delete(DATASET, destinationTableName));
1283+
assertTrue(bigquery.delete(destinationTable));
12841284
}
12851285

12861286
@Test
@@ -1330,7 +1330,7 @@ public void testCreateAndGetJobWithSelectedFields()
13301330
RetryOption.totalTimeout(Duration.ofMinutes(1)));
13311331
assertNotNull(completedJob);
13321332
assertNull(completedJob.getStatus().getError());
1333-
assertTrue(bigquery.delete(DATASET, destinationTableName));
1333+
assertTrue(bigquery.delete(destinationTable));
13341334
}
13351335

13361336
@Test
@@ -1388,7 +1388,7 @@ public void testQueryJob() throws InterruptedException, TimeoutException {
13881388
rowCount++;
13891389
}
13901390
assertEquals(2, rowCount);
1391-
assertTrue(bigquery.delete(DATASET, tableName));
1391+
assertTrue(bigquery.delete(destinationTable));
13921392
Job queryJob = bigquery.getJob(remoteJob.getJobId());
13931393
JobStatistics.QueryStatistics statistics = queryJob.getStatistics();
13941394
assertNotNull(statistics.getQueryPlan());
@@ -1435,7 +1435,7 @@ public void testExtractJob() throws InterruptedException, TimeoutException {
14351435
new String(storage.readAllBytes(BUCKET, EXTRACT_FILE), StandardCharsets.UTF_8);
14361436
assertEquals(
14371437
Sets.newHashSet(CSV_CONTENT.split("\n")), Sets.newHashSet(extractedCsv.split("\n")));
1438-
assertTrue(bigquery.delete(DATASET, tableName));
1438+
assertTrue(bigquery.delete(destinationTable));
14391439
}
14401440

14411441
@Test
@@ -1532,7 +1532,7 @@ public void testInsertFromFile() throws InterruptedException, IOException, Timeo
15321532
rowCount++;
15331533
}
15341534
assertEquals(2, rowCount);
1535-
assertTrue(bigquery.delete(DATASET, destinationTableName));
1535+
assertTrue(bigquery.delete(tableId));
15361536
}
15371537

15381538
@Test

0 commit comments

Comments
 (0)