Skip to content

Commit e4c612f

Browse files
Patrick Huangtcoffee-google
authored andcommitted
---
yaml --- r: 8179 b: refs/heads/tswast-patch-1 c: 6bd2e32 h: refs/heads/master i: 8177: 7277914 8175: 2160085
1 parent c9cfe7d commit e4c612f

5 files changed

Lines changed: 19 additions & 5 deletions

File tree

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,5 +57,5 @@ refs/tags/v0.18.0: 9d193c4c4b9d1c6f21515dd8e50836b9194ec9bb
5757
refs/tags/v0.19.0: e67b56e4d8dad5f9a7b38c9b2107c23c828f2ed5
5858
refs/tags/v0.20.0: 839f7fb7156535146aa1cb2c5aadd8d375d854e8
5959
refs/tags/v0.20.1: 370471f437f1f4f68a11e068df5cd6bf39edb1fa
60-
refs/heads/tswast-patch-1: 3d9a08451826714593fdf309704b8d902a994d99
60+
refs/heads/tswast-patch-1: 6bd2e329a9274404a8429c163cd4892f47c3ca2b
6161
refs/heads/pubsub-streaming-pull: 19262b752ee874eb2ca3b950eb2aef44d5a5267b

branches/tswast-patch-1/google-cloud-translate/src/main/java/com/google/cloud/translate/Translate.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,16 @@ public static TranslateOption targetLanguage(String targetLanguage) {
9595
public static TranslateOption model(String model) {
9696
return new TranslateOption(TranslateRpc.Option.MODEL, model);
9797
}
98+
99+
/**
100+
* Sets the format of the source text, in either HTML (default) or plain-text.
101+
* A value of {@code html} indicates HTML and a value of {@code text} indicates plain-text.
102+
*
103+
* @param format the format of the source text
104+
*/
105+
public static TranslateOption format(String format) {
106+
return new TranslateOption(TranslateRpc.Option.FORMAT, format);
107+
}
98108
}
99109

100110
/**

branches/tswast-patch-1/google-cloud-translate/src/main/java/com/google/cloud/translate/spi/v2/HttpTranslateRpc.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,7 @@ public List<TranslationsResource> translate(List<String> texts, Map<Option, ?> o
126126
.setSource(sourceLanguage)
127127
.setKey(options.getApiKey())
128128
.set("model", Option.MODEL.getString(optionMap))
129+
.setFormat(Option.FORMAT.getString(optionMap))
129130
.execute()
130131
.getTranslations();
131132
return Lists.transform(

branches/tswast-patch-1/google-cloud-translate/src/main/java/com/google/cloud/translate/spi/v2/TranslateRpc.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@ public interface TranslateRpc extends ServiceRpc {
2929
enum Option {
3030
SOURCE_LANGUAGE("source"),
3131
TARGET_LANGUAGE("target"),
32-
MODEL("model");
32+
MODEL("model"),
33+
FORMAT("format");
3334

3435
private final String value;
3536

branches/tswast-patch-1/google-cloud-translate/src/test/java/com/google/cloud/translate/TranslateImplTest.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,11 +91,13 @@ public class TranslateImplTest {
9191
private static final TranslateOption SOURCE_LANGUAGE_OPTION =
9292
TranslateOption.sourceLanguage("de");
9393
private static final TranslateOption MODEL_OPTION = TranslateOption.model("nmt");
94+
private static final TranslateOption FORMAT_OPTION = TranslateOption.format("text");
9495
private static final Map<TranslateRpc.Option, ?> TRANSLATE_OPTIONS =
9596
ImmutableMap.of(
9697
TranslateRpc.Option.TARGET_LANGUAGE, TARGET_LANGUAGE_OPTION.getValue(),
9798
TranslateRpc.Option.SOURCE_LANGUAGE, SOURCE_LANGUAGE_OPTION.getValue(),
98-
TranslateRpc.Option.MODEL, "nmt");
99+
TranslateRpc.Option.MODEL, "nmt",
100+
TranslateRpc.Option.FORMAT, "text");
99101
private static final RetrySettings NO_RETRY_SETTINGS = ServiceOptions.getNoRetrySettings();
100102

101103
private TranslateOptions options;
@@ -316,7 +318,7 @@ public void testTranslateWithOptions() {
316318
initializeService();
317319
assertEquals(
318320
TRANSLATION2,
319-
translate.translate(text, TARGET_LANGUAGE_OPTION, SOURCE_LANGUAGE_OPTION, MODEL_OPTION));
321+
translate.translate(text, TARGET_LANGUAGE_OPTION, SOURCE_LANGUAGE_OPTION, MODEL_OPTION, FORMAT_OPTION));
320322
verify();
321323
}
322324

@@ -343,7 +345,7 @@ public void testTranslateListWithOptions() {
343345
initializeService();
344346
assertEquals(
345347
ImmutableList.of(TRANSLATION2),
346-
translate.translate(texts, TARGET_LANGUAGE_OPTION, SOURCE_LANGUAGE_OPTION, MODEL_OPTION));
348+
translate.translate(texts, TARGET_LANGUAGE_OPTION, SOURCE_LANGUAGE_OPTION, MODEL_OPTION, FORMAT_OPTION));
347349
verify();
348350
}
349351

0 commit comments

Comments
 (0)