Make batch delete return false if not found

mziccard · mziccard · commit e22e8a3e6d60 · 2015-11-17T16:55:42.000+01:00
diff --git a/gcloud-java-storage/src/main/java/com/google/gcloud/spi/DefaultStorageRpc.java b/gcloud-java-storage/src/main/java/com/google/gcloud/spi/DefaultStorageRpc.java
@@ -368,7 +368,11 @@ public void onSuccess(Void ignore, HttpHeaders responseHeaders) {
 
           @Override
           public void onFailure(GoogleJsonError e, HttpHeaders responseHeaders) {
-            deletes.put(tuple.x(), Tuple.<Boolean, StorageException>of(null, translate(e)));
+            if (e.getCode() == 404) {
+              deletes.put(tuple.x(), Tuple.<Boolean, StorageException>of(Boolean.FALSE, null));
+            } else {
+              deletes.put(tuple.x(), Tuple.<Boolean, StorageException>of(null, translate(e)));
+            }
           }
         });
       }
diff --git a/gcloud-java-storage/src/test/java/com/google/gcloud/storage/ITStorageTest.java b/gcloud-java-storage/src/test/java/com/google/gcloud/storage/ITStorageTest.java
@@ -644,7 +644,8 @@ public void testBatchRequestFail() {
     assertFalse(batchResponse.gets().get(1).failed());
     assertNull(batchResponse.gets().get(1).get());
     assertTrue(batchResponse.deletes().get(0).failed());
-    assertTrue(batchResponse.deletes().get(1).failed());
+    assertFalse(batchResponse.deletes().get(1).failed());
+    assertFalse(batchResponse.deletes().get(1).get());
     assertTrue(storage.delete(BUCKET, blobName));
   }
 

Original file line number	Diff line number	Diff line change
`@@ -368,7 +368,11 @@ public void onSuccess(Void ignore, HttpHeaders responseHeaders) {`
`368`	`368`
`369`	`369`	`@Override`
`370`	`370`	`public void onFailure(GoogleJsonError e, HttpHeaders responseHeaders) {`
`371`		`- deletes.put(tuple.x(), Tuple.<Boolean, StorageException>of(null, translate(e)));`
	`371`	`+ if (e.getCode() == 404) {`
	`372`	`+ deletes.put(tuple.x(), Tuple.<Boolean, StorageException>of(Boolean.FALSE, null));`
	`373`	`+ } else {`
	`374`	`+ deletes.put(tuple.x(), Tuple.<Boolean, StorageException>of(null, translate(e)));`
	`375`	`+ }`
`372`	`376`	`}`
`373`	`377`	`});`
`374`	`378`	`}`
Original file line number	Diff line number	Diff line change
`@@ -644,7 +644,8 @@ public void testBatchRequestFail() {`
`644`	`644`	`assertFalse(batchResponse.gets().get(1).failed());`
`645`	`645`	`assertNull(batchResponse.gets().get(1).get());`
`646`	`646`	`assertTrue(batchResponse.deletes().get(0).failed());`
`647`		`- assertTrue(batchResponse.deletes().get(1).failed());`
	`647`	`+ assertFalse(batchResponse.deletes().get(1).failed());`
	`648`	`+ assertFalse(batchResponse.deletes().get(1).get());`
`648`	`649`	`assertTrue(storage.delete(BUCKET, blobName));`
`649`	`650`	`}`
`650`	`651`