pubsub: clarify sleep-then-stop in snippet (#2617)

pongad · web-flow · commit e2165af332ec · 2017-11-13T14:18:36.000+11:00
Fixes #2616
diff --git a/google-cloud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/CreateSubscriptionAndConsumeMessages.java b/google-cloud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/CreateSubscriptionAndConsumeMessages.java
@@ -62,10 +62,13 @@ public void failed(Subscriber.State from, Throwable failure) {
           MoreExecutors.directExecutor());
       subscriber.startAsync().awaitRunning();
 
+      // In this example, we will pull messages for one minute (60,000ms) then stop.
+      // In a real application, this sleep-then-stop is not necessary.
+      // Simply call stopAsync().awaitTerminated() when the server is shutting down, etc.
       Thread.sleep(60000);
     } finally {
       if (subscriber != null) {
-        subscriber.stopAsync();
+        subscriber.stopAsync().awaitTerminated();
       }
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -62,10 +62,13 @@ public void failed(Subscriber.State from, Throwable failure) {`
`62`	`62`	`MoreExecutors.directExecutor());`
`63`	`63`	`subscriber.startAsync().awaitRunning();`
`64`	`64`
	`65`	`+ // In this example, we will pull messages for one minute (60,000ms) then stop.`
	`66`	`+ // In a real application, this sleep-then-stop is not necessary.`
	`67`	`+ // Simply call stopAsync().awaitTerminated() when the server is shutting down, etc.`
`65`	`68`	`Thread.sleep(60000);`
`66`	`69`	`} finally {`
`67`	`70`	`if (subscriber != null) {`
`68`		`- subscriber.stopAsync();`
	`71`	`+ subscriber.stopAsync().awaitTerminated();`
`69`	`72`	`}`
`70`	`73`	`}`
`71`	`74`	`}`