Remove duplicate span.end() causing log pollution. (#4497)

snehashah16 · web-flow · commit e195b5f60b79 · 2019-02-14T13:14:09.000-08:00
diff --git a/google-cloud-clients/google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerImpl.java b/google-cloud-clients/google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerImpl.java
@@ -1291,7 +1291,6 @@ public <T> T run(TransactionCallable<T> callable) {
         // We also do this unconditionally in case a user has modified the flag when the transaction
         // was running.
         hasPendingTransaction.remove();
-        span.end();
       }
     }
 
@@ -2627,7 +2626,6 @@ public void close(@Nullable String message) {
       if (stream != null) {
         stream.close(message);
       }
-      span.end();
     }
 
     @Override

Original file line number	Diff line number	Diff line change
`@@ -1291,7 +1291,6 @@ public <T> T run(TransactionCallable<T> callable) {`
`1291`	`1291`	`// We also do this unconditionally in case a user has modified the flag when the transaction`
`1292`	`1292`	`// was running.`
`1293`	`1293`	`hasPendingTransaction.remove();`
`1294`		`- span.end();`
`1295`	`1294`	`}`
`1296`	`1295`	`}`
`1297`	`1296`
`@@ -2627,7 +2626,6 @@ public void close(@Nullable String message) {`
`2627`	`2626`	`if (stream != null) {`
`2628`	`2627`	`stream.close(message);`
`2629`	`2628`	`}`
`2630`		`- span.end();`
`2631`	`2629`	`}`
`2632`	`2630`
`2633`	`2631`	`@Override`