Skip to content

Commit e146344

Browse files
---
yaml --- r: 8359 b: refs/heads/snehashah-snippets c: 199d95c h: refs/heads/master i: 8357: 158fbf4 8355: ef1cb3a 8351: b3a1757
1 parent 8b24d71 commit e146344

2 files changed

Lines changed: 7 additions & 17 deletions

File tree

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ refs/tags/v0.18.0: 9d193c4c4b9d1c6f21515dd8e50836b9194ec9bb
5656
refs/tags/v0.19.0: e67b56e4d8dad5f9a7b38c9b2107c23c828f2ed5
5757
refs/tags/v0.20.0: 839f7fb7156535146aa1cb2c5aadd8d375d854e8
5858
refs/tags/v0.20.1: 370471f437f1f4f68a11e068df5cd6bf39edb1fa
59-
refs/heads/snehashah-snippets: 82fa63d01fe19b5158f258f2a2991378e074ab0f
59+
refs/heads/snehashah-snippets: 199d95c3b228006a4968ab8e41e12aff099b111f
6060
refs/tags/v0.20.2: 5a53aa06f268b74dc192204f4f83e1a04d40f65d
6161
refs/tags/v0.20.3: 269025fdc14af0b68df214a4518be5379b2fe569
6262
refs/tags/v0.21.0: f88b200e00e41ba6262ee88a92abba38b1e2417e

branches/snehashah-snippets/google-cloud-logging/src/test/java/com/google/cloud/logging/BaseSystemTest.java

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -148,14 +148,9 @@ public void testUpdateNonExistingSink() {
148148
.setVersionFormat(SinkInfo.VersionFormat.V2)
149149
.build();
150150
assertNull(logging().getSink(name));
151-
Sink sink = logging().update(sinkInfo);
152-
assertEquals(name, sink.getName());
153-
assertEquals(SinkInfo.VersionFormat.V2, sink.getVersionFormat());
154-
assertEquals("severity>=ERROR", sink.getFilter());
155-
DatasetDestination datasetDestination = sink.getDestination();
156-
assertEquals(logging().getOptions().getProjectId(), datasetDestination.getProject());
157-
assertEquals("dataset", datasetDestination.getDataset());
158-
assertTrue(logging().deleteSink(name));
151+
thrown.expect(LoggingException.class);
152+
thrown.expectMessage("NOT_FOUND");
153+
logging().update(sinkInfo);
159154
}
160155

161156
@Test
@@ -166,14 +161,9 @@ public void testUpdateNonExistingSinkAsync() throws ExecutionException, Interrup
166161
.setVersionFormat(SinkInfo.VersionFormat.V2)
167162
.build();
168163
assertNull(logging().getSinkAsync(name).get());
169-
Sink sink = logging().updateAsync(sinkInfo).get();
170-
assertEquals(name, sink.getName());
171-
assertEquals(SinkInfo.VersionFormat.V2, sink.getVersionFormat());
172-
assertEquals("severity>=ERROR", sink.getFilter());
173-
DatasetDestination datasetDestination = sink.getDestination();
174-
assertEquals(logging().getOptions().getProjectId(), datasetDestination.getProject());
175-
assertEquals("dataset", datasetDestination.getDataset());
176-
assertTrue(logging().deleteSinkAsync(name).get());
164+
thrown.expect(ExecutionException.class);
165+
thrown.expectMessage("NOT_FOUND");
166+
logging().updateAsync(sinkInfo).get();
177167
}
178168

179169
@Test

0 commit comments

Comments
 (0)