Skip to content

Commit e0dbb7e

Browse files
committed
Add javadoc tu PubSubSnippets, remove unused @rule, fix snippets names
1 parent 5bcf665 commit e0dbb7e

2 files changed

Lines changed: 7 additions & 8 deletions

File tree

google-cloud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/PubSubSnippets.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,9 @@
4646
import java.util.concurrent.Future;
4747
import java.util.concurrent.TimeUnit;
4848

49+
/**
50+
* This class contains a number of snippets for the {@link PubSub} interface.
51+
*/
4952
public class PubSubSnippets {
5053

5154
private final PubSub pubsub;
@@ -205,12 +208,12 @@ public String publishOneMessage(String topicName) {
205208
// [VARIABLE "my_topic_name"]
206209
public String publishOneMessageAsync(String topicName)
207210
throws ExecutionException, InterruptedException {
208-
// [START publishOneMessage]
211+
// [START publishOneMessageAsync]
209212
Message message = Message.of("payload");
210213
Future<String> future = pubsub.publishAsync(topicName, message);
211214
// ...
212215
String messageId = future.get();
213-
// [END publishOneMessage]
216+
// [END publishOneMessageAsync]
214217
return messageId;
215218
}
216219

@@ -220,12 +223,12 @@ public String publishOneMessageAsync(String topicName)
220223
// [TARGET publish(String, Iterable)]
221224
// [VARIABLE "my_topic_name"]
222225
public List<String> publishMessageList(String topicName) {
223-
// [START publishOneMessageAsync]
226+
// [START publishMessageList]
224227
List<Message> messages = new LinkedList<>();
225228
messages.add(Message.of("payload1"));
226229
messages.add(Message.of("payload2"));
227230
List<String> messageIds = pubsub.publish(topicName, messages);
228-
// [END publishOneMessageAsync]
231+
// [END publishMessageList]
229232
return messageIds;
230233
}
231234

google-cloud-examples/src/test/java/com/google/cloud/examples/pubsub/snippets/ITPubSubSnippets.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
import org.junit.BeforeClass;
4141
import org.junit.Rule;
4242
import org.junit.Test;
43-
import org.junit.rules.ExpectedException;
4443
import org.junit.rules.Timeout;
4544

4645
import java.util.HashSet;
@@ -60,9 +59,6 @@ public class ITPubSubSnippets {
6059
@Rule
6160
public Timeout globalTimeout = Timeout.seconds(300);
6261

63-
@Rule
64-
public ExpectedException thrown = ExpectedException.none();
65-
6662
private static String formatForTest(String resourceName) {
6763
return resourceName + "-" + NAME_SUFFIX;
6864
}

0 commit comments

Comments
 (0)