Propagate page size error to user

Ajay Kannan · Ajay Kannan · commit df32901b0d71 · 2016-02-18T09:51:13.000-08:00
diff --git a/gcloud-java-resourcemanager/src/main/java/com/google/gcloud/resourcemanager/testing/LocalResourceManagerHelper.java b/gcloud-java-resourcemanager/src/main/java/com/google/gcloud/resourcemanager/testing/LocalResourceManagerHelper.java
@@ -228,7 +228,7 @@ private static String[] parseFields(String query) {
     return null;
   }
 
-  private static Map<String, Object> parseListOptions(String query) {
+  private static Map<String, Object> parseListOptions(String query) throws IOException {
     Map<String, Object> options = new HashMap<>();
     if (query != null) {
       String[] args = query.split("&");
@@ -249,7 +249,9 @@ private static Map<String, Object> parseListOptions(String query) {
             break;
           case "pageSize":
             int pageSize = Integer.valueOf(argEntry[1]);
-            checkArgument(pageSize > 0, "Page size must be greater than 0.");
+            if (pageSize < 1) {
+              throw new IOException("Page size must be greater than 0.");
+            }
             options.put("pageSize", pageSize);
             break;
         }
diff --git a/gcloud-java-resourcemanager/src/test/java/com/google/gcloud/resourcemanager/LocalResourceManagerHelperTest.java b/gcloud-java-resourcemanager/src/test/java/com/google/gcloud/resourcemanager/LocalResourceManagerHelperTest.java
@@ -297,6 +297,17 @@ public void testList() {
     }
   }
 
+  @Test
+  public void testInvalidListPaging() {
+    Map<ResourceManagerRpc.Option, Object> rpcOptions = new HashMap<>();
+    rpcOptions.put(ResourceManagerRpc.Option.PAGE_SIZE, -1);
+    try {
+      rpc.list(rpcOptions);
+    } catch (Exception e) {
+      assertEquals("Page size must be greater than 0.", e.getMessage());
+    }
+  }
+
   @Test
   public void testListPaging() {
     Map<ResourceManagerRpc.Option, Object> rpcOptions = new HashMap<>();
