Addressing some Codacy comments

garrettjonesgoogle · garrettjonesgoogle · commit ded535750643 · 2017-04-18T12:59:13.000-07:00
diff --git a/google-cloud-core/src/main/java/com/google/cloud/StringEnumValue.java b/google-cloud-core/src/main/java/com/google/cloud/StringEnumValue.java
@@ -24,8 +24,11 @@
  * a context.
  */
 public abstract class StringEnumValue {
-  private String constant;
+  private final String constant;
 
+  /**
+   * Don't create subclasses outside of google-cloud-java.
+   */
   @InternalApi
   protected StringEnumValue(String constant) {
     this.constant = Preconditions.checkNotNull(constant);
diff --git a/google-cloud-core/src/test/java/com/google/cloud/StringEnumTest.java b/google-cloud-core/src/test/java/com/google/cloud/StringEnumTest.java
@@ -34,21 +34,21 @@ private Letter(String constant) {
       super(constant);
     }
 
-    private static ApiFunction<String, Letter> CONSTRUCTOR =
+    private static final ApiFunction<String, Letter> CONSTRUCTOR =
         new ApiFunction<String, Letter>() {
           @Override
           public Letter apply(String constant) {
             return new Letter(constant);
           }
         };
 
-    private static StringEnumType<Letter> type = new StringEnumType(
+    private static final StringEnumType<Letter> type = new StringEnumType(
         Letter.class,
         CONSTRUCTOR);
 
-    public static Letter A = type.createAndRegister("A");
-    public static Letter B = type.createAndRegister("B");
-    public static Letter C = type.createAndRegister("C");
+    public static final Letter A = type.createAndRegister("A");
+    public static final Letter B = type.createAndRegister("B");
+    public static final Letter C = type.createAndRegister("C");
 
     public static Letter valueOfStrict(String constant) {
       return type.valueOfStrict(constant);
diff --git a/google-cloud-storage/src/main/java/com/google/cloud/storage/StorageClass.java b/google-cloud-storage/src/main/java/com/google/cloud/storage/StorageClass.java
@@ -29,47 +29,47 @@ private StorageClass(String constant) {
     super(constant);
   }
 
-  private static ApiFunction<String, StorageClass> CONSTRUCTOR =
+  private static final ApiFunction<String, StorageClass> CONSTRUCTOR =
       new ApiFunction<String, StorageClass>() {
         @Override
         public StorageClass apply(String constant) {
           return new StorageClass(constant);
         }
       };
 
-  private static StringEnumType<StorageClass> type = new StringEnumType(
+  private static final StringEnumType<StorageClass> type = new StringEnumType(
       StorageClass.class,
       CONSTRUCTOR);
 
   /**
    * Regional storage class.
    */
-  public static StorageClass REGIONAL = type.createAndRegister("REGIONAL");
+  public static final StorageClass REGIONAL = type.createAndRegister("REGIONAL");
 
   /**
    * Multi-regional storage class.
    */
-  public static StorageClass MULTI_REGIONAL = type.createAndRegister("MULTI_REGIONAL");
+  public static final StorageClass MULTI_REGIONAL = type.createAndRegister("MULTI_REGIONAL");
 
   /**
    * Nearline storage class.
    */
-  public static StorageClass NEARLINE = type.createAndRegister("NEARLINE");
+  public static final StorageClass NEARLINE = type.createAndRegister("NEARLINE");
 
   /**
    * Coldline storage class.
    */
-  public static StorageClass COLDLINE = type.createAndRegister("COLDLINE");
+  public static final StorageClass COLDLINE = type.createAndRegister("COLDLINE");
 
   /**
    * Standard storage class.
    */
-  public static StorageClass STANDARD = type.createAndRegister("STANDARD");
+  public static final StorageClass STANDARD = type.createAndRegister("STANDARD");
 
   /**
    * Durable Reduced Availability (deprecated)
    */
-  public static StorageClass DURABLE_REDUCED_AVAILABILITY = type.createAndRegister(
+  public static final StorageClass DURABLE_REDUCED_AVAILABILITY = type.createAndRegister(
       "DURABLE_REDUCED_AVAILABILITY");
 
   /**
