Remove public modifiers from channels StateImpl Builder

mziccard · mziccard · commit dcbe37fab40c · 2015-10-19T12:30:03.000+02:00
diff --git a/gcloud-java-storage/src/main/java/com/google/gcloud/storage/BlobReadChannelImpl.java b/gcloud-java-storage/src/main/java/com/google/gcloud/storage/BlobReadChannelImpl.java
@@ -167,7 +167,7 @@ static class StateImpl implements RestorableState<BlobReadChannel>, Serializable
       this.chunkSize = builder.chunkSize;
     }
 
-    public static class Builder {
+    static class Builder {
       private final StorageOptions serviceOptions;
       private final BlobId blob;
       private final Map<StorageRpc.Option, ?> requestOptions;
@@ -182,32 +182,32 @@ private Builder(StorageOptions options, BlobId blob, Map<StorageRpc.Option, ?> r
         this.requestOptions = reqOptions;
       }
 
-      public Builder position(int position) {
+      Builder position(int position) {
         this.position = position;
         return this;
       }
 
-      public Builder isOpen(boolean isOpen) {
+      Builder isOpen(boolean isOpen) {
         this.isOpen = isOpen;
         return this;
       }
 
-      public Builder endOfStream(boolean endOfStream) {
+      Builder endOfStream(boolean endOfStream) {
         this.endOfStream = endOfStream;
         return this;
       }
 
-      public Builder chunkSize(int chunkSize) {
+      Builder chunkSize(int chunkSize) {
         this.chunkSize = chunkSize;
         return this;
       }
 
-      public RestorableState<BlobReadChannel> build() {
+      RestorableState<BlobReadChannel> build() {
         return new StateImpl(this);
       }
     }
 
-    public static Builder builder(
+    static Builder builder(
         StorageOptions options, BlobId blob, Map<StorageRpc.Option, ?> reqOptions) {
       return new Builder(options, blob, reqOptions);
     }
diff --git a/gcloud-java-storage/src/main/java/com/google/gcloud/storage/BlobWriteChannelImpl.java b/gcloud-java-storage/src/main/java/com/google/gcloud/storage/BlobWriteChannelImpl.java
@@ -180,7 +180,7 @@ static class StateImpl implements RestorableState<BlobWriteChannel>, Serializabl
       this.chunkSize = builder.chunkSize;
     }
 
-    public static class Builder {
+    static class Builder {
       private final StorageOptions serviceOptions;
       private final BlobInfo blobInfo;
       private final String uploadId;
@@ -196,37 +196,37 @@ private Builder(StorageOptions options, BlobInfo blobInfo, String uploadId) {
         this.uploadId = uploadId;
       }
 
-      public Builder position(int position) {
+      Builder position(int position) {
         this.position = position;
         return this;
       }
 
-      public Builder buffer(byte[] buffer) {
+      Builder buffer(byte[] buffer) {
         this.buffer = buffer.clone();
         return this;
       }
 
-      public Builder limit(int limit) {
+      Builder limit(int limit) {
         this.limit = limit;
         return this;
       }
 
-      public Builder isOpen(boolean isOpen) {
+      Builder isOpen(boolean isOpen) {
         this.isOpen = isOpen;
         return this;
       }
 
-      public Builder chunkSize(int chunkSize) {
+      Builder chunkSize(int chunkSize) {
         this.chunkSize = chunkSize;
         return this;
       }
 
-      public RestorableState<BlobWriteChannel> build() {
+      RestorableState<BlobWriteChannel> build() {
         return new StateImpl(this);
       }
     }
 
-    public static Builder builder(StorageOptions options, BlobInfo blobInfo, String uploadId) {
+    static Builder builder(StorageOptions options, BlobInfo blobInfo, String uploadId) {
       return new Builder(options, blobInfo, uploadId);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -167,7 +167,7 @@ static class StateImpl implements RestorableState<BlobReadChannel>, Serializable`
`167`	`167`	`this.chunkSize = builder.chunkSize;`
`168`	`168`	`}`
`169`	`169`
`170`		`- public static class Builder {`
	`170`	`+ static class Builder {`
`171`	`171`	`private final StorageOptions serviceOptions;`
`172`	`172`	`private final BlobId blob;`
`173`	`173`	`private final Map<StorageRpc.Option, ?> requestOptions;`
`@@ -182,32 +182,32 @@ private Builder(StorageOptions options, BlobId blob, Map<StorageRpc.Option, ?> r`
`182`	`182`	`this.requestOptions = reqOptions;`
`183`	`183`	`}`
`184`	`184`
`185`		`- public Builder position(int position) {`
	`185`	`+ Builder position(int position) {`
`186`	`186`	`this.position = position;`
`187`	`187`	`return this;`
`188`	`188`	`}`
`189`	`189`
`190`		`- public Builder isOpen(boolean isOpen) {`
	`190`	`+ Builder isOpen(boolean isOpen) {`
`191`	`191`	`this.isOpen = isOpen;`
`192`	`192`	`return this;`
`193`	`193`	`}`
`194`	`194`
`195`		`- public Builder endOfStream(boolean endOfStream) {`
	`195`	`+ Builder endOfStream(boolean endOfStream) {`
`196`	`196`	`this.endOfStream = endOfStream;`
`197`	`197`	`return this;`
`198`	`198`	`}`
`199`	`199`
`200`		`- public Builder chunkSize(int chunkSize) {`
	`200`	`+ Builder chunkSize(int chunkSize) {`
`201`	`201`	`this.chunkSize = chunkSize;`
`202`	`202`	`return this;`
`203`	`203`	`}`
`204`	`204`
`205`		`- public RestorableState<BlobReadChannel> build() {`
	`205`	`+ RestorableState<BlobReadChannel> build() {`
`206`	`206`	`return new StateImpl(this);`
`207`	`207`	`}`
`208`	`208`	`}`
`209`	`209`
`210`		`- public static Builder builder(`
	`210`	`+ static Builder builder(`
`211`	`211`	`StorageOptions options, BlobId blob, Map<StorageRpc.Option, ?> reqOptions) {`
`212`	`212`	`return new Builder(options, blob, reqOptions);`
`213`	`213`	`}`
Original file line number	Diff line number	Diff line change
`@@ -180,7 +180,7 @@ static class StateImpl implements RestorableState<BlobWriteChannel>, Serializabl`
`180`	`180`	`this.chunkSize = builder.chunkSize;`
`181`	`181`	`}`
`182`	`182`
`183`		`- public static class Builder {`
	`183`	`+ static class Builder {`
`184`	`184`	`private final StorageOptions serviceOptions;`
`185`	`185`	`private final BlobInfo blobInfo;`
`186`	`186`	`private final String uploadId;`
`@@ -196,37 +196,37 @@ private Builder(StorageOptions options, BlobInfo blobInfo, String uploadId) {`
`196`	`196`	`this.uploadId = uploadId;`
`197`	`197`	`}`
`198`	`198`
`199`		`- public Builder position(int position) {`
	`199`	`+ Builder position(int position) {`
`200`	`200`	`this.position = position;`
`201`	`201`	`return this;`
`202`	`202`	`}`
`203`	`203`
`204`		`- public Builder buffer(byte[] buffer) {`
	`204`	`+ Builder buffer(byte[] buffer) {`
`205`	`205`	`this.buffer = buffer.clone();`
`206`	`206`	`return this;`
`207`	`207`	`}`
`208`	`208`
`209`		`- public Builder limit(int limit) {`
	`209`	`+ Builder limit(int limit) {`
`210`	`210`	`this.limit = limit;`
`211`	`211`	`return this;`
`212`	`212`	`}`
`213`	`213`
`214`		`- public Builder isOpen(boolean isOpen) {`
	`214`	`+ Builder isOpen(boolean isOpen) {`
`215`	`215`	`this.isOpen = isOpen;`
`216`	`216`	`return this;`
`217`	`217`	`}`
`218`	`218`
`219`		`- public Builder chunkSize(int chunkSize) {`
	`219`	`+ Builder chunkSize(int chunkSize) {`
`220`	`220`	`this.chunkSize = chunkSize;`
`221`	`221`	`return this;`
`222`	`222`	`}`
`223`	`223`
`224`		`- public RestorableState<BlobWriteChannel> build() {`
	`224`	`+ RestorableState<BlobWriteChannel> build() {`
`225`	`225`	`return new StateImpl(this);`
`226`	`226`	`}`
`227`	`227`	`}`
`228`	`228`
`229`		`- public static Builder builder(StorageOptions options, BlobInfo blobInfo, String uploadId) {`
	`229`	`+ static Builder builder(StorageOptions options, BlobInfo blobInfo, String uploadId) {`
`230`	`230`	`return new Builder(options, blobInfo, uploadId);`
`231`	`231`	`}`
`232`	`232`