Pub/Sub: Streamining publisher proto creation. (#5040)

sduskis · web-flow · commit d2f0bc64a530 · 2019-04-30T15:06:30.000-04:00
Using a prebuit List is faster than adding elements one at a time to a proto list.
diff --git a/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java b/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java
@@ -272,13 +272,13 @@ public void publishAllOutstanding() {
   }
 
   private ApiFuture<PublishResponse> publishCall(OutstandingBatch outstandingBatch) {
-    PublishRequest.Builder publishRequest = PublishRequest.newBuilder();
-    publishRequest.setTopic(topicName);
-    for (OutstandingPublish outstandingPublish : outstandingBatch.outstandingPublishes) {
-      publishRequest.addMessages(outstandingPublish.message);
-    }
-
-    return publisherStub.publishCallable().futureCall(publishRequest.build());
+    return publisherStub
+        .publishCallable()
+        .futureCall(
+            PublishRequest.newBuilder()
+                .setTopic(topicName)
+                .addAllMessages(outstandingBatch.getMessages())
+                .build());
   }
 
   private void publishOutstandingBatch(final OutstandingBatch outstandingBatch) {
@@ -342,6 +342,14 @@ private static final class OutstandingBatch {
     int size() {
       return outstandingPublishes.size();
     }
+
+    private List<PubsubMessage> getMessages() {
+      List<PubsubMessage> results = new ArrayList<>(outstandingPublishes.size());
+      for (OutstandingPublish outstandingPublish : outstandingPublishes) {
+        results.add(outstandingPublish.message);
+      }
+      return results;
+    }
   }
 
   private static final class OutstandingPublish {
