Skip to content

Commit ce20c3a

Browse files
committed
---
yaml --- r: 2831 b: refs/heads/dns-alpha c: a47158d h: refs/heads/master i: 2829: afca291 2827: 779b81d 2823: 77ebc76 2815: 50411a6
1 parent ac1e955 commit ce20c3a

2 files changed

Lines changed: 22 additions & 21 deletions

File tree

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ refs/tags/v0.0.10: 207ebd2a3472fddee69fe1298eb90429e3306efd
1111
refs/tags/v0.0.11: ffbfba48a6426ff63c08ff2117e58681f251fbf2
1212
refs/tags/v0.0.12: 2fd8066e891fb3dfea69b65f6bf6461db79342b9
1313
refs/heads/compute-alpha: b1274b5bdf4eea955f3588b56378a5ae4ba59cef
14-
refs/heads/dns-alpha: 9b4ff48b64c2192a42d914a672d9004e59a4b822
14+
refs/heads/dns-alpha: a47158db527eeb220534189ee24c7837f75bddda

branches/dns-alpha/gcloud-java-dns/src/main/java/com/google/gcloud/dns/ProjectInfo.java

Lines changed: 21 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,14 @@
2626

2727
/**
2828
* The class that encapsulates information about a project in Google Cloud DNS. A project is a top
29-
* level container for resources including {@link ManagedZone}s. Projects can be created only in the
29+
* level container for resources including {@code ManagedZone}s. Projects can be created only in the
3030
* APIs console.
3131
*
3232
* @see <a href="https://cloud.google.com/dns/api/v1/projects">Google Cloud DNS documentation</a>
3333
*/
3434
public class ProjectInfo implements Serializable {
3535

36-
private static final long serialVersionUID = 201601251420L;
36+
private static final long serialVersionUID = 8696578863323485036L;
3737
private final String id;
3838
private final BigInteger number;
3939
private final Quota quota;
@@ -55,8 +55,9 @@ public static class Quota {
5555
/**
5656
* Creates an instance of {@code Quota}.
5757
*
58-
* This is the only way of creating an instance of {@code Quota}. As the service does not allow
59-
* for specifying options, quota is an "all-or-nothing object" and we do not need a builder.
58+
* <p>This is the only way of creating an instance of {@code Quota}. As the service does not
59+
* allow for specifying options, quota is an "all-or-nothing object" and we do not need a
60+
* builder.
6061
*/
6162
Quota(Integer zones,
6263
Integer resourceRecordsPerRrset,
@@ -102,7 +103,7 @@ public Integer rrsetDeletionsPerChange() {
102103
}
103104

104105
/**
105-
* Returns the maximum allowed number of {@link DnsRecord}s per {@link ManagedZone} in the
106+
* Returns the maximum allowed number of {@link DnsRecord}s per {@code ManagedZone} in the
106107
* project.
107108
*/
108109
public Integer rrsetsPerManagedZone() {
@@ -117,8 +118,8 @@ public Integer totalRrdataSizePerChange() {
117118
}
118119

119120
@Override
120-
public boolean equals(Object o) {
121-
return (o instanceof Quota) && this.toPb().equals(((Quota) o).toPb());
121+
public boolean equals(Object other) {
122+
return (other instanceof Quota) && this.toPb().equals(((Quota) other).toPb());
122123
}
123124

124125
@Override
@@ -139,14 +140,14 @@ com.google.api.services.dns.model.Quota toPb() {
139140
}
140141

141142
static Quota fromPb(com.google.api.services.dns.model.Quota pb) {
142-
Quota q = new Quota(pb.getManagedZones(),
143+
Quota quota = new Quota(pb.getManagedZones(),
143144
pb.getResourceRecordsPerRrset(),
144145
pb.getRrsetAdditionsPerChange(),
145146
pb.getRrsetDeletionsPerChange(),
146147
pb.getRrsetsPerManagedZone(),
147148
pb.getTotalRrdataSizePerChange()
148149
);
149-
return q;
150+
return quota;
150151
}
151152

152153
@Override
@@ -205,10 +206,10 @@ ProjectInfo build() {
205206
}
206207
}
207208

208-
private ProjectInfo(Builder b) {
209-
this.id = b.id;
210-
this.number = b.number;
211-
this.quota = b.quota;
209+
private ProjectInfo(Builder builder) {
210+
this.id = builder.id;
211+
this.number = builder.number;
212+
this.quota = builder.quota;
212213
}
213214

214215
/**
@@ -250,22 +251,22 @@ com.google.api.services.dns.model.Project toPb() {
250251
}
251252

252253
static ProjectInfo fromPb(com.google.api.services.dns.model.Project pb) {
253-
Builder b = builder();
254+
Builder builder = builder();
254255
if (pb.getId() != null) {
255-
b.id(pb.getId());
256+
builder.id(pb.getId());
256257
}
257258
if (pb.getNumber() != null) {
258-
b.number(pb.getNumber());
259+
builder.number(pb.getNumber());
259260
}
260261
if (pb.getQuota() != null) {
261-
b.quota(Quota.fromPb(pb.getQuota()));
262+
builder.quota(Quota.fromPb(pb.getQuota()));
262263
}
263-
return b.build();
264+
return builder.build();
264265
}
265266

266267
@Override
267-
public boolean equals(Object o) {
268-
return (o instanceof ProjectInfo) && this.toPb().equals(((ProjectInfo) o).toPb());
268+
public boolean equals(Object other) {
269+
return (other instanceof ProjectInfo) && this.toPb().equals(((ProjectInfo) other).toPb());
269270
}
270271

271272
@Override

0 commit comments

Comments
 (0)