Skip to content

Commit c92bc2d

Browse files
committed
Use Collections.singletonList
1 parent 27256d4 commit c92bc2d

File tree

2 files changed

+12
-22
lines changed

2 files changed

+12
-22
lines changed

google-cloud-examples/src/main/java/com/google/cloud/examples/spanner/snippets/DatabaseClientSnippets.java

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,7 @@
3232
import com.google.cloud.spanner.TransactionContext;
3333
import com.google.cloud.spanner.TransactionRunner;
3434
import com.google.cloud.spanner.TransactionRunner.TransactionCallable;
35-
import java.util.ArrayList;
3635
import java.util.Collections;
37-
import java.util.List;
3836
import java.util.concurrent.TimeUnit;
3937

4038
/**
@@ -55,17 +53,15 @@ public DatabaseClientSnippets(DatabaseClient dbClient) {
5553
// [VARIABLE my_singer_id]
5654
public void write(long singerId) {
5755
// [START write]
58-
List<Mutation> mutations = new ArrayList<>();
59-
mutations.add(
60-
Mutation.newInsertBuilder("Singer")
56+
Mutation mutation = Mutation.newInsertBuilder("Singer")
6157
.set("SingerId")
6258
.to(singerId)
6359
.set("FirstName")
6460
.to("Billy")
6561
.set("LastName")
6662
.to("Joel")
67-
.build());
68-
dbClient.write(mutations);
63+
.build();
64+
dbClient.write(Collections.singletonList(mutation));
6965
// [END write]
7066
}
7167

@@ -76,17 +72,15 @@ public void write(long singerId) {
7672
// [VARIABLE my_singer_id]
7773
public void writeAtLeastOnce(long singerId) {
7874
// [START writeAtLeastOnce]
79-
List<Mutation> mutations = new ArrayList<>();
80-
mutations.add(
81-
Mutation.newInsertBuilder("Singers")
75+
Mutation mutation = Mutation.newInsertBuilder("Singers")
8276
.set("SingerId")
8377
.to(singerId)
8478
.set("FirstName")
8579
.to("Billy")
8680
.set("LastName")
8781
.to("Joel")
88-
.build());
89-
dbClient.writeAtLeastOnce(mutations);
82+
.build();
83+
dbClient.writeAtLeastOnce(Collections.singletonList(mutation));
9084
// [END writeAtLeastOnce]
9185
}
9286

google-cloud-spanner/src/main/java/com/google/cloud/spanner/DatabaseClient.java

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -36,17 +36,15 @@ public interface DatabaseClient {
3636
* <p>Example of blind write.
3737
* <pre> {@code
3838
* long singerId = my_singer_id;
39-
* List<Mutation> mutations = new ArrayList<>();
40-
* mutations.add(
41-
* Mutation.newInsertBuilder("Singer")
39+
* Mutation mutation = Mutation.newInsertBuilder("Singer")
4240
* .set("SingerId")
4341
* .to(singerId)
4442
* .set("FirstName")
4543
* .to("Billy")
4644
* .set("LastName")
4745
* .to("Joel")
48-
* .build());
49-
* dbClient.write(mutations);
46+
* .build();
47+
* dbClient.write(Collections.singletonList(mutation));
5048
* }</pre>
5149
*
5250
* @return the timestamp at which the write was committed
@@ -68,17 +66,15 @@ public interface DatabaseClient {
6866
* <p>Example of unprotected blind write.
6967
* <pre> {@code
7068
* long singerId = my_singer_id;
71-
* List<Mutation> mutations = new ArrayList<>();
72-
* mutations.add(
73-
* Mutation.newInsertBuilder("Singers")
69+
* Mutation mutation = Mutation.newInsertBuilder("Singers")
7470
* .set("SingerId")
7571
* .to(singerId)
7672
* .set("FirstName")
7773
* .to("Billy")
7874
* .set("LastName")
7975
* .to("Joel")
80-
* .build());
81-
* dbClient.writeAtLeastOnce(mutations);
76+
* .build();
77+
* dbClient.writeAtLeastOnce(Collections.singletonList(mutation));
8278
* }</pre>
8379
*
8480
* @return the timestamp at which the write was committed

0 commit comments

Comments
 (0)