---

mziccard · mziccard · commit c42b17f40e49 · 2016-01-05T09:37:57.000+01:00
yaml --- r: 2117 b: refs/heads/pubsub-alpha c: 46f7958 h: refs/heads/master i: 2115: 45b4621
diff --git a/[refs] b/[refs]
@@ -3,7 +3,7 @@ refs/heads/master: 689bbb466df4b2d5d2483d6edb8ac5c7c7f7c6fa
 refs/heads/travis: e21ee7b88a5edc3f3d8c71f90c3fc32abf7e8dd6
 refs/heads/gh-pages: 4e0561bb4504bf647db669a14417b2b2c87ba45d
 refs/heads/bigquery: 762fa5830e6c398c0396177e3e7fd243bd62cfc3
-refs/heads/pubsub-alpha: 70b350cf8eb61a051adfd5cc9b10ffa952225ee6
+refs/heads/pubsub-alpha: 46f7958e2f39848469f7aa8537da42d707ed3585
 refs/heads/resource-manager: ebf4adc5ee835cd2086c4ac5b4e78d01a5a005a7
 refs/heads/update-datastore: 482954f2c5055231e5b3122ea91d2ba00ce8187c
 refs/tags/0.0.9: 22f1839238f66c39e67ed4dfdcd273b1ae2e8444
diff --git a/branches/pubsub-alpha/gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/InsertAllRequest.java b/branches/pubsub-alpha/gcloud-java-bigquery/src/main/java/com/google/gcloud/bigquery/InsertAllRequest.java
@@ -236,7 +236,16 @@ public Builder ignoreUnknownValues(boolean ignoreUnknownValues) {
     /**
      * If specified, the destination table is treated as a base template. Rows are inserted into an
      * instance table named "{destination}{templateSuffix}". BigQuery will manage the creation of
-     * the instance table, using the schema of the base template table.
+     * the instance table, using the schema of the base template table. Table creation might take
+     * some time. To obtain table's information after {@link BigQuery#insertAll(InsertAllRequest)}
+     * is called use:
+     * <pre> {@code
+     * String suffixTableId = ...;
+     * BaseTableInfo suffixTable = bigquery.getTable(DATASET, suffixTableId);
+     * while (suffixTable == null) {
+     *   Thread.sleep(1000L);
+     *   suffixTable = bigquery.getTable(DATASET, suffixTableId);
+     * }}</pre>
      *
      * @see <a
      *     href="https://cloud.google.com/bigquery/streaming-data-into-bigquery#template-tables">
@@ -293,7 +302,16 @@ public Boolean skipInvalidRows() {
   /**
    * If specified, the destination table is treated as a base template. Rows are inserted into an
    * instance table named "{destination}{templateSuffix}". BigQuery will manage the creation of the
-   * instance table, using the schema of the base template table.
+   * instance table, using the schema of the base template table. Table creation might take some
+   * time. To obtain table's information after {@link BigQuery#insertAll(InsertAllRequest)} is
+   * called use:
+   * <pre> {@code
+   * String suffixTableId = ...;
+   * BaseTableInfo suffixTable = bigquery.getTable(DATASET, suffixTableId);
+   * while (suffixTable == null) {
+   *   Thread.sleep(1000L);
+   *   suffixTable = bigquery.getTable(DATASET, suffixTableId);
+   * }}</pre>
    *
    * @see <a
    *     href="https://cloud.google.com/bigquery/streaming-data-into-bigquery#template-tables">
diff --git a/branches/pubsub-alpha/gcloud-java-bigquery/src/test/java/com/google/gcloud/bigquery/ITBigQueryTest.java b/branches/pubsub-alpha/gcloud-java-bigquery/src/test/java/com/google/gcloud/bigquery/ITBigQueryTest.java
@@ -506,11 +506,11 @@ public void testInsertAllWithSuffix() throws InterruptedException {
     assertEquals(0, response.insertErrors().size());
     String newTableName = tableName + "_suffix";
     BaseTableInfo suffixTable = bigquery.getTable(DATASET, newTableName, TableOption.fields());
+    // wait until the new table is created. If the table is never created the test will time-out
     while (suffixTable == null) {
       Thread.sleep(1000L);
       suffixTable = bigquery.getTable(DATASET, newTableName, TableOption.fields());
     }
-    assertNotNull(suffixTable);
     assertTrue(bigquery.delete(TableId.of(DATASET, tableName)));
     assertTrue(bigquery.delete(TableId.of(DATASET, newTableName)));
   }

Original file line number	Diff line number	Diff line change
`@@ -506,11 +506,11 @@ public void testInsertAllWithSuffix() throws InterruptedException {`
`506`	`506`	`assertEquals(0, response.insertErrors().size());`
`507`	`507`	`String newTableName = tableName + "_suffix";`
`508`	`508`	`BaseTableInfo suffixTable = bigquery.getTable(DATASET, newTableName, TableOption.fields());`
	`509`	`+ // wait until the new table is created. If the table is never created the test will time-out`
`509`	`510`	`while (suffixTable == null) {`
`510`	`511`	`Thread.sleep(1000L);`
`511`	`512`	`suffixTable = bigquery.getTable(DATASET, newTableName, TableOption.fields());`
`512`	`513`	`}`
`513`		`- assertNotNull(suffixTable);`
`514`	`514`	`assertTrue(bigquery.delete(TableId.of(DATASET, tableName)));`
`515`	`515`	`assertTrue(bigquery.delete(TableId.of(DATASET, newTableName)));`
`516`	`516`	`}`