make JobConfiguration.Type enum public (#1736)

neozwu · web-flow · commit c268bb0e8151 · 2017-03-10T16:49:39.000-08:00
* add UTs

* style fix
diff --git a/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/JobConfiguration.java b/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/JobConfiguration.java
@@ -36,7 +36,7 @@ public abstract class JobConfiguration implements Serializable {
   /**
    * Type of a BigQuery Job.
    */
-  enum Type {
+  public enum Type {
     /**
      * A Copy Job copies an existing table to another new or existing table. Instances of
      * {@code JobConfiguration} for this type are implemented by {@link CopyJobConfiguration}.
diff --git a/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/CopyJobConfigurationTest.java b/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/CopyJobConfigurationTest.java
@@ -118,6 +118,12 @@ public void testSetProjectId() {
     }
   }
 
+  @Test
+  public void testGetType() {
+    assertEquals(JobConfiguration.Type.COPY, COPY_JOB_CONFIGURATION.getType());
+    assertEquals(JobConfiguration.Type.COPY, COPY_JOB_CONFIGURATION_MULTIPLE_TABLES.getType());
+  }
+
   private void compareCopyJobConfiguration(CopyJobConfiguration expected,
       CopyJobConfiguration value) {
     assertEquals(expected, value);
diff --git a/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/ExtractJobConfigurationTest.java b/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/ExtractJobConfigurationTest.java
@@ -125,6 +125,12 @@ public void testSetProjectId() {
     assertEquals("p", configuration.getSourceTable().getProject());
   }
 
+  @Test
+  public void testGetType() {
+    assertEquals(JobConfiguration.Type.EXTRACT, EXTRACT_CONFIGURATION.getType());
+    assertEquals(JobConfiguration.Type.EXTRACT, EXTRACT_CONFIGURATION_ONE_URI.getType());
+  }
+
   private void compareExtractJobConfiguration(ExtractJobConfiguration expected,
       ExtractJobConfiguration value) {
     assertEquals(expected, value);
diff --git a/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/LoadJobConfigurationTest.java b/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/LoadJobConfigurationTest.java
@@ -109,6 +109,11 @@ public void testSetProjectId() {
     assertEquals("p", configuration.getDestinationTable().getProject());
   }
 
+  @Test
+  public void testGetType() {
+    assertEquals(JobConfiguration.Type.LOAD, LOAD_CONFIGURATION.getType());
+  }
+
   private void compareLoadJobConfiguration(LoadJobConfiguration expected,
       LoadJobConfiguration value) {
     assertEquals(expected, value);
diff --git a/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/QueryJobConfigurationTest.java b/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/QueryJobConfigurationTest.java
@@ -19,18 +19,15 @@
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertNull;
-import static org.junit.Assert.assertTrue;
 
 import com.google.cloud.bigquery.JobInfo.CreateDisposition;
 import com.google.cloud.bigquery.JobInfo.WriteDisposition;
 import com.google.cloud.bigquery.QueryJobConfiguration.Priority;
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableMap;
-
-import org.junit.Test;
-
 import java.util.List;
 import java.util.Map;
+import org.junit.Test;
 
 public class QueryJobConfigurationTest {
 
@@ -134,6 +131,11 @@ public void testSetProjectId() {
     assertEquals("p", configuration.getDestinationTable().getProject());
   }
 
+  @Test
+  public void testGetType() {
+    assertEquals(JobConfiguration.Type.QUERY, QUERY_JOB_CONFIGURATION.getType());
+  }
+
   private void compareQueryJobConfiguration(QueryJobConfiguration expected,
       QueryJobConfiguration value) {
     assertEquals(expected, value);

Original file line number	Diff line number	Diff line change
`@@ -118,6 +118,12 @@ public void testSetProjectId() {`
`118`	`118`	`}`
`119`	`119`	`}`
`120`	`120`
	`121`	`+ @Test`
	`122`	`+ public void testGetType() {`
	`123`	`+ assertEquals(JobConfiguration.Type.COPY, COPY_JOB_CONFIGURATION.getType());`
	`124`	`+ assertEquals(JobConfiguration.Type.COPY, COPY_JOB_CONFIGURATION_MULTIPLE_TABLES.getType());`
	`125`	`+ }`
	`126`	`+`
`121`	`127`	`private void compareCopyJobConfiguration(CopyJobConfiguration expected,`
`122`	`128`	`CopyJobConfiguration value) {`
`123`	`129`	`assertEquals(expected, value);`