---

Ajay Kannan · Ajay Kannan · commit b5703d7d3ab7 · 2015-10-28T10:40:59.000-07:00
yaml --- r: 2335 b: refs/heads/update-datastore c: f2dc019 h: refs/heads/master i: 2333: 60d43c9 2331: 9c90c39 2327: 1ca805b 2319: 7274e3d 2303: b7ae943
diff --git a/[refs] b/[refs]
@@ -5,7 +5,7 @@ refs/heads/gh-pages: 4e0561bb4504bf647db669a14417b2b2c87ba45d
 refs/heads/bigquery: 762fa5830e6c398c0396177e3e7fd243bd62cfc3
 refs/heads/pubsub-alpha: 1a0e970f265af871e02274085b9662b3fe29058b
 refs/heads/resource-manager: ebf4adc5ee835cd2086c4ac5b4e78d01a5a005a7
-refs/heads/update-datastore: 41f607d05500615ef79712ac59716a59990edb37
+refs/heads/update-datastore: f2dc019ebc193c5af9e7ed3b7e2030bc97faf1ef
 refs/tags/0.0.9: 22f1839238f66c39e67ed4dfdcd273b1ae2e8444
 refs/tags/v0.0.10: 207ebd2a3472fddee69fe1298eb90429e3306efd
 refs/tags/v0.0.11: ffbfba48a6426ff63c08ff2117e58681f251fbf2
diff --git a/branches/update-datastore/gcloud-java-core/src/main/java/com/google/gcloud/ServiceOptions.java b/branches/update-datastore/gcloud-java-core/src/main/java/com/google/gcloud/ServiceOptions.java
@@ -411,8 +411,6 @@ private static boolean isWindows() {
   }
 
   protected static String getAppEngineProjectId() {
-    // TODO(ozarov): An alternative to reflection would be to depend on AE api jar:
-    // http://mvnrepository.com/artifact/com.google.appengine/appengine-api-1.0-sdk/1.2.0
     try {
       Class<?> factoryClass =
           Class.forName("com.google.appengine.api.appidentity.AppIdentityServiceFactory");
diff --git a/branches/update-datastore/gcloud-java-datastore/src/main/java/com/google/gcloud/datastore/DatastoreOptions.java b/branches/update-datastore/gcloud-java-datastore/src/main/java/com/google/gcloud/datastore/DatastoreOptions.java
@@ -172,8 +172,6 @@ public String namespace() {
   }
 
   private static String defaultNamespace() {
-    // TODO(ozarov): An alternative to reflection would be to depend on AE api jar:
-    // http://mvnrepository.com/artifact/com.google.appengine/appengine-api-1.0-sdk/1.2.0
     try {
       Class<?> clazz = Class.forName("com.google.appengine.api.NamespaceManager");
       Method method = clazz.getMethod("get");
diff --git a/branches/update-datastore/gcloud-java-datastore/src/test/java/com/google/gcloud/datastore/DatastoreTest.java b/branches/update-datastore/gcloud-java-datastore/src/test/java/com/google/gcloud/datastore/DatastoreTest.java
@@ -459,7 +459,6 @@ public void testRunStructuredQuery() {
     assertEquals("Dan", entity.getString("name"));
     assertEquals(2, entity.properties().size());
     assertFalse(results4.hasNext());
-    // TODO(ozarov): construct a test to verify nextQuery/pagination
   }
 
   @Test

Original file line number	Diff line number	Diff line change
`@@ -411,8 +411,6 @@ private static boolean isWindows() {`
`411`	`411`	`}`
`412`	`412`
`413`	`413`	`protected static String getAppEngineProjectId() {`
`414`		`- // TODO(ozarov): An alternative to reflection would be to depend on AE api jar:`
`415`		`- // http://mvnrepository.com/artifact/com.google.appengine/appengine-api-1.0-sdk/1.2.0`
`416`	`414`	`try {`
`417`	`415`	`Class<?> factoryClass =`
`418`	`416`	`Class.forName("com.google.appengine.api.appidentity.AppIdentityServiceFactory");`
Original file line number	Diff line number	Diff line change
`@@ -172,8 +172,6 @@ public String namespace() {`
`172`	`172`	`}`
`173`	`173`
`174`	`174`	`private static String defaultNamespace() {`
`175`		`- // TODO(ozarov): An alternative to reflection would be to depend on AE api jar:`
`176`		`- // http://mvnrepository.com/artifact/com.google.appengine/appengine-api-1.0-sdk/1.2.0`
`177`	`175`	`try {`
`178`	`176`	`Class<?> clazz = Class.forName("com.google.appengine.api.NamespaceManager");`
`179`	`177`	`Method method = clazz.getMethod("get");`
Original file line number	Diff line number	Diff line change
`@@ -459,7 +459,6 @@ public void testRunStructuredQuery() {`
`459`	`459`	`assertEquals("Dan", entity.getString("name"));`
`460`	`460`	`assertEquals(2, entity.properties().size());`
`461`	`461`	`assertFalse(results4.hasNext());`
`462`		`- // TODO(ozarov): construct a test to verify nextQuery/pagination`
`463`	`462`	`}`
`464`	`463`
`465`	`464`	`@Test`