Skip to content

Commit b55686c

Browse files
schmidt-sebastianpongad
authored andcommitted
---
yaml --- r: 9415 b: refs/heads/spanner-gapic-migration c: 0097ffa h: refs/heads/master i: 9413: 1c43b60 9411: 4669b76 9407: ff85fcf
1 parent dca9637 commit b55686c

5 files changed

Lines changed: 24 additions & 25 deletions

File tree

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ refs/tags/v0.34.0: bf31760a31a66acb239322a70dcd03dbe1d0c7ca
8080
refs/tags/v0.35.0: c28951c5f4cc97a1be07900d19df6984115a4bd6
8181
refs/tags/v0.36.0: 6b75c61f73e6827b3ca379bd54f88f750290162f
8282
refs/tags/v0.37.0: db2e142f92601709fdd48db159776f905742e30f
83-
refs/heads/spanner-gapic-migration: 87b19d669c988a892dc32ee0af6370fcde9dd77e
83+
refs/heads/spanner-gapic-migration: 0097ffa5fc1e1fe590c1c5e9e2a4b7c458a944d5
8484
refs/tags/v0.38.0: c235ee4df5e1248e1769dae3f86a0d7ab7fd8301
8585
refs/tags/v0.39.0: ab231c9d22475242a43d6d9554aa4a3f736dab01
8686
refs/tags/v0.40.0: a1d5b05206cce7734365f1b910396a2c9d6605ec

branches/spanner-gapic-migration/google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreImpl.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -147,13 +147,9 @@ public void onNext(BatchGetDocumentsResponse response) {
147147

148148
numResponses++;
149149
if (numResponses == 1) {
150-
tracer
151-
.getCurrentSpan()
152-
.addAnnotation("Firestore.BatchGet: First response");
150+
tracer.getCurrentSpan().addAnnotation("Firestore.BatchGet: First response");
153151
} else if (numResponses % 100 == 0) {
154-
tracer
155-
.getCurrentSpan()
156-
.addAnnotation("Firestore.BatchGet: Received 100 responses");
152+
tracer.getCurrentSpan().addAnnotation("Firestore.BatchGet: Received 100 responses");
157153
}
158154

159155
switch (response.getResultCase()) {

branches/spanner-gapic-migration/google-cloud-firestore/src/main/java/com/google/cloud/firestore/Query.java

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -924,7 +924,8 @@ private void stream(
924924
request.setTransaction(transactionId);
925925
}
926926

927-
Tracing.getTracer().getCurrentSpan()
927+
Tracing.getTracer()
928+
.getCurrentSpan()
928929
.addAnnotation(
929930
"Firestore.Query: Start",
930931
ImmutableMap.of(
@@ -940,13 +941,13 @@ private void stream(
940941
public void onNext(RunQueryResponse response) {
941942
if (!firstResponse) {
942943
firstResponse = true;
943-
Tracing.getTracer().getCurrentSpan()
944-
.addAnnotation("Firestore.Query: First response");
944+
Tracing.getTracer().getCurrentSpan().addAnnotation("Firestore.Query: First response");
945945
}
946946
if (response.hasDocument()) {
947947
numDocuments++;
948948
if (numDocuments % 100 == 0) {
949-
Tracing.getTracer().getCurrentSpan()
949+
Tracing.getTracer()
950+
.getCurrentSpan()
950951
.addAnnotation("Firestore.Query: Received 100 documents");
951952
}
952953
Document document = response.getDocument();
@@ -970,12 +971,12 @@ public void onError(Throwable throwable) {
970971

971972
@Override
972973
public void onCompleted() {
973-
Tracing.getTracer().getCurrentSpan()
974+
Tracing.getTracer()
975+
.getCurrentSpan()
974976
.addAnnotation(
975977
"Firestore.Query: Completed",
976978
ImmutableMap.of(
977-
"numDocuments",
978-
AttributeValue.longAttributeValue(numDocuments)));
979+
"numDocuments", AttributeValue.longAttributeValue(numDocuments)));
979980
documentObserver.onCompleted(readTime);
980981
}
981982
};

branches/spanner-gapic-migration/google-cloud-firestore/src/main/java/com/google/cloud/firestore/UpdateBuilder.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -578,9 +578,11 @@ private T performDelete(
578578

579579
/** Commit the current batch. */
580580
ApiFuture<List<WriteResult>> commit(@Nullable ByteString transactionId) {
581-
Tracing.getTracer().getCurrentSpan().addAnnotation(
582-
"CloudFirestore.Commit",
583-
ImmutableMap.of("numDocuments", AttributeValue.longAttributeValue(mutations.size())));
581+
Tracing.getTracer()
582+
.getCurrentSpan()
583+
.addAnnotation(
584+
"CloudFirestore.Commit",
585+
ImmutableMap.of("numDocuments", AttributeValue.longAttributeValue(mutations.size())));
584586

585587
final CommitRequest.Builder request = CommitRequest.newBuilder();
586588
request.setDatabase(firestore.getDatabaseName());

branches/spanner-gapic-migration/google-cloud-firestore/src/test/java/com/google/cloud/firestore/QueryTest.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -536,16 +536,16 @@ public void getResult() throws Exception {
536536
Iterator<DocumentChange> changeIterator = result.getDocumentChanges().iterator();
537537

538538
DocumentChange documentChange = changeIterator.next();
539-
assertEquals("doc1",documentChange.getDocument().getId());
540-
assertEquals(DocumentChange.Type.ADDED,documentChange.getType());
541-
assertEquals(-1,documentChange.getOldIndex());
542-
assertEquals(0,documentChange.getNewIndex());
539+
assertEquals("doc1", documentChange.getDocument().getId());
540+
assertEquals(DocumentChange.Type.ADDED, documentChange.getType());
541+
assertEquals(-1, documentChange.getOldIndex());
542+
assertEquals(0, documentChange.getNewIndex());
543543

544544
documentChange = changeIterator.next();
545-
assertEquals("doc2",documentChange.getDocument().getId());
546-
assertEquals(DocumentChange.Type.ADDED,documentChange.getType());
547-
assertEquals(-1,documentChange.getOldIndex());
548-
assertEquals(1,documentChange.getNewIndex());
545+
assertEquals("doc2", documentChange.getDocument().getId());
546+
assertEquals(DocumentChange.Type.ADDED, documentChange.getType());
547+
assertEquals(-1, documentChange.getOldIndex());
548+
assertEquals(1, documentChange.getNewIndex());
549549

550550
assertFalse(changeIterator.hasNext());
551551

0 commit comments

Comments
 (0)