Make ExceptionHandler conform with our code style

mziccard · mziccard · commit b28b3079539e · 2015-11-11T21:55:39.000+01:00
diff --git a/gcloud-java-core/src/main/java/com/google/gcloud/ExceptionHandler.java b/gcloud-java-core/src/main/java/com/google/gcloud/ExceptionHandler.java
@@ -231,11 +231,11 @@ void verifyCaller(Callable<?> callable) {
     }
   }
 
-  public Set<Class<? extends Exception>> getRetriableExceptions() {
+  public Set<Class<? extends Exception>> retriableExceptions() {
     return retriableExceptions;
   }
 
-  public Set<Class<? extends Exception>> getNonRetriableExceptions() {
+  public Set<Class<? extends Exception>> nonRetriableExceptions() {
     return nonRetriableExceptions;
   }
 
@@ -262,7 +262,7 @@ boolean shouldRetry(Exception ex) {
   /**
    * Returns an instance which retry any checked exception and abort on any runtime exception.
    */
-  public static ExceptionHandler getDefaultInstance() {
+  public static ExceptionHandler defaultInstance() {
     return DEFAULT_INSTANCE;
   }
 
diff --git a/gcloud-java-core/src/main/java/com/google/gcloud/RetryHelper.java b/gcloud-java-core/src/main/java/com/google/gcloud/RetryHelper.java
@@ -229,7 +229,7 @@ private static long getExponentialValue(long initialDelay, double backoffFactor,
 
   public static <V> V runWithRetries(Callable<V> callable) throws RetryHelperException {
     return runWithRetries(callable, RetryParams.defaultInstance(),
-        ExceptionHandler.getDefaultInstance());
+        ExceptionHandler.defaultInstance());
   }
 
   public static <V> V runWithRetries(Callable<V> callable, RetryParams params,
diff --git a/gcloud-java-core/src/test/java/com/google/gcloud/ExceptionHandlerTest.java b/gcloud-java-core/src/test/java/com/google/gcloud/ExceptionHandlerTest.java
@@ -82,7 +82,7 @@ public Object call() throws Error {
     }
 
     // using default exception handler (retry upon any non-runtime exceptions)
-    ExceptionHandler handler = ExceptionHandler.getDefaultInstance();
+    ExceptionHandler handler = ExceptionHandler.defaultInstance();
     assertValidCallable(new A(), handler);
     assertValidCallable(new B(), handler);
     assertValidCallable(new C(), handler);
diff --git a/gcloud-java-core/src/test/java/com/google/gcloud/RetryHelperTest.java b/gcloud-java-core/src/test/java/com/google/gcloud/RetryHelperTest.java
@@ -124,7 +124,7 @@ public void testTriesAtLeastMinTimes() {
         }
         return timesCalled;
       }
-    }, params, ExceptionHandler.getDefaultInstance());
+    }, params, ExceptionHandler.defaultInstance());
     assertEquals(timesToFail + 1, attempted);
     assertNull(RetryHelper.getContext());
   }

Original file line number	Diff line number	Diff line change
`@@ -231,11 +231,11 @@ void verifyCaller(Callable<?> callable) {`
`231`	`231`	`}`
`232`	`232`	`}`
`233`	`233`
`234`		`- public Set<Class<? extends Exception>> getRetriableExceptions() {`
	`234`	`+ public Set<Class<? extends Exception>> retriableExceptions() {`
`235`	`235`	`return retriableExceptions;`
`236`	`236`	`}`
`237`	`237`
`238`		`- public Set<Class<? extends Exception>> getNonRetriableExceptions() {`
	`238`	`+ public Set<Class<? extends Exception>> nonRetriableExceptions() {`
`239`	`239`	`return nonRetriableExceptions;`
`240`	`240`	`}`
`241`	`241`
`@@ -262,7 +262,7 @@ boolean shouldRetry(Exception ex) {`
`262`	`262`	`/**`
`263`	`263`	`* Returns an instance which retry any checked exception and abort on any runtime exception.`
`264`	`264`	`*/`
`265`		`- public static ExceptionHandler getDefaultInstance() {`
	`265`	`+ public static ExceptionHandler defaultInstance() {`
`266`	`266`	`return DEFAULT_INSTANCE;`
`267`	`267`	`}`
`268`	`268`
Original file line number	Diff line number	Diff line change
`@@ -229,7 +229,7 @@ private static long getExponentialValue(long initialDelay, double backoffFactor,`
`229`	`229`
`230`	`230`	`public static <V> V runWithRetries(Callable<V> callable) throws RetryHelperException {`
`231`	`231`	`return runWithRetries(callable, RetryParams.defaultInstance(),`
`232`		`- ExceptionHandler.getDefaultInstance());`
	`232`	`+ ExceptionHandler.defaultInstance());`
`233`	`233`	`}`
`234`	`234`
`235`	`235`	`public static <V> V runWithRetries(Callable<V> callable, RetryParams params,`
Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ public Object call() throws Error {`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`// using default exception handler (retry upon any non-runtime exceptions)`
`85`		`- ExceptionHandler handler = ExceptionHandler.getDefaultInstance();`
	`85`	`+ ExceptionHandler handler = ExceptionHandler.defaultInstance();`
`86`	`86`	`assertValidCallable(new A(), handler);`
`87`	`87`	`assertValidCallable(new B(), handler);`
`88`	`88`	`assertValidCallable(new C(), handler);`
Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ public void testTriesAtLeastMinTimes() {`
`124`	`124`	`}`
`125`	`125`	`return timesCalled;`
`126`	`126`	`}`
`127`		`- }, params, ExceptionHandler.getDefaultInstance());`
	`127`	`+ }, params, ExceptionHandler.defaultInstance());`
`128`	`128`	`assertEquals(timesToFail + 1, attempted);`
`129`	`129`	`assertNull(RetryHelper.getContext());`
`130`	`130`	`}`