pubsub: delete Subscriber.Builder::setCredentials

pongad · pongad · commit af98a13d0f01 · 2017-04-24T14:18:18.000+10:00
The credentials provided to this method is not used. Currently the credentials should be set in the ChannelProvider. Updates #1959.
diff --git a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Subscriber.java b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Subscriber.java
@@ -27,7 +27,6 @@
 import com.google.api.gax.grpc.ChannelProvider;
 import com.google.api.gax.grpc.ExecutorProvider;
 import com.google.api.gax.grpc.InstantiatingExecutorProvider;
-import com.google.auth.Credentials;
 import com.google.auth.oauth2.GoogleCredentials;
 import com.google.common.annotations.VisibleForTesting;
 import com.google.common.base.Optional;
@@ -196,7 +195,8 @@ public FlowControlSettings getFlowControlSettings() {
    * Initiates service startup and returns immediately.
    *
    * <p>Example of receiving a specific number of messages.
-   * <pre> {@code
+   *
+   * <pre>{@code
    * Subscriber subscriber = Subscriber.defaultBuilder(subscription, receiver).build();
    * subscriber.addListener(new Subscriber.Listener() {
    *   public void failed(Subscriber.State from, Throwable failure) {
@@ -209,7 +209,6 @@ public FlowControlSettings getFlowControlSettings() {
    * done.get();
    * subscriber.stopAsync().awaitTerminated();
    * }</pre>
-   *
    */
   @Override
   public ApiService startAsync() {
@@ -450,7 +449,6 @@ public static final class Builder {
             .build();
 
     SubscriptionName subscriptionName;
-    Optional<Credentials> credentials = Optional.absent();
     MessageReceiver receiver;
 
     Duration ackExpirationPadding = DEFAULT_ACK_EXPIRATION_PADDING;
@@ -471,16 +469,6 @@ public static final class Builder {
       this.receiver = receiver;
     }
 
-    /**
-     * Credentials to authenticate with.
-     *
-     * <p>Must be properly scoped for accessing Cloud Pub/Sub APIs.
-     */
-    public Builder setCredentials(Credentials credentials) {
-      this.credentials = Optional.of(Preconditions.checkNotNull(credentials));
-      return this;
-    }
-
     /**
      * {@code ChannelProvider} to use to create Channels, which must point at Cloud Pub/Sub
      * endpoint.
@@ -539,15 +527,15 @@ public Builder setExecutorProvider(ExecutorProvider executorProvider) {
       return this;
     }
 
-    /** 
-     * Gives the ability to set a custom executor for managing lease extensions. If none is
-     * provided a shared one will be used by all {@link Subscriber} instances.
+    /**
+     * Gives the ability to set a custom executor for managing lease extensions. If none is provided
+     * a shared one will be used by all {@link Subscriber} instances.
      */
     public Builder setLeaseAlarmsExecutorProvider(ExecutorProvider executorProvider) {
       this.alarmsExecutorProvider = Preconditions.checkNotNull(executorProvider);
       return this;
     }
-    
+
     /** Gives the ability to set a custom clock. */
     Builder setClock(ApiClock clock) {
       this.clock = Optional.of(clock);
