Skip to content

Commit aa85ae9

Browse files
shollymansduskis
authored andcommitted
---
yaml --- r: 35355 b: refs/heads/pubsub-ordering-keys c: 5f045ef h: refs/heads/master i: 35353: 8d41142 35351: 1d3c42c
1 parent 8e0b32b commit aa85ae9

3 files changed

Lines changed: 3 additions & 13 deletions

File tree

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ refs/tags/v0.72.0: a7703f2593ba312c0b2dde6fdfd4f5c764bb55ac
155155
refs/tags/v0.73.0: 21241ea8be9439cc5764c4944cdce21d34ce4f9e
156156
refs/tags/v0.74.0: 9d1f733dbbf790de7b494418523b69c4a9a57638
157157
refs/heads/ignoretest: 23c412ae07af3d0ab1caa2d44d5bc5c0ccb8b31d
158-
refs/heads/pubsub-ordering-keys: 7f07a1adf7c6adaed14791fa1f059bdc7284571a
158+
refs/heads/pubsub-ordering-keys: 5f045ef212c60e819c6d5ba374b838036a19441b
159159
refs/tags/v0.75.0: c3673089ae09a897c1b4cf7dfe167fe4f8ab32fb
160160
refs/tags/v0.76.0: 395b016826d3ddf9cb8b34919636df15a4dbd032
161161
refs/tags/v0.77.0: 28a85a77883ccf5d48f297fd0ef3b3dca6ce01f0

branches/pubsub-ordering-keys/google-cloud-clients/google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1beta1/stub/EnhancedBigQueryStorageStubSettingsTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ public void testCreateReadSessionSettings() {
120120
public void testReadRowsSettings() {
121121
ServerStreamingCallSettings.Builder<ReadRowsRequest, ReadRowsResponse> builder =
122122
EnhancedBigQueryStorageStubSettings.newBuilder().readRowsSettings();
123-
assertThat(builder.getRetryableCodes()).containsAllOf(Code.DEADLINE_EXCEEDED, Code.UNAVAILABLE);
123+
assertThat(builder.getRetryableCodes()).contains(Code.UNAVAILABLE);
124124
RetrySettings retrySettings = builder.getRetrySettings();
125125
assertThat(retrySettings.getInitialRetryDelay()).isEqualTo(Duration.ofMillis(100L));
126126
assertThat(retrySettings.getRetryDelayMultiplier()).isWithin(1e-6).of(1.3);
@@ -157,7 +157,7 @@ public void testSplitReadStreamSettings() {
157157
}
158158

159159
private void verifyRetrySettings(Set<Code> retryCodes, RetrySettings retrySettings) {
160-
assertThat(retryCodes).containsAllOf(Code.DEADLINE_EXCEEDED, Code.UNAVAILABLE);
160+
assertThat(retryCodes).contains(Code.UNAVAILABLE);
161161
assertThat(retrySettings.getTotalTimeout()).isGreaterThan(Duration.ZERO);
162162
assertThat(retrySettings.getInitialRetryDelay()).isGreaterThan(Duration.ZERO);
163163
assertThat(retrySettings.getRetryDelayMultiplier()).isAtLeast(1.0);

branches/pubsub-ordering-keys/google-cloud-clients/google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1beta1/stub/readrows/ReadRowsRetryTest.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -112,11 +112,6 @@ public void multipleRetryTestWithZeroInitialOffset() {
112112
.respondWithNumberOfRows(5)
113113
.respondWithStatus(Code.UNAVAILABLE));
114114

115-
service.expectations.add(
116-
RpcExpectation.create()
117-
.expectRequest("fake-stream", 5)
118-
.respondWithStatus(Code.DEADLINE_EXCEEDED));
119-
120115
service.expectations.add(
121116
RpcExpectation.create()
122117
.expectRequest("fake-stream", 5)
@@ -139,11 +134,6 @@ public void multipleRetryTestWithNonZeroInitialOffset() {
139134
.respondWithNumberOfRows(5)
140135
.respondWithStatus(Code.UNAVAILABLE));
141136

142-
service.expectations.add(
143-
RpcExpectation.create()
144-
.expectRequest("fake-stream", 22)
145-
.respondWithStatus(Code.DEADLINE_EXCEEDED));
146-
147137
service.expectations.add(
148138
RpcExpectation.create()
149139
.expectRequest("fake-stream", 22)

0 commit comments

Comments
 (0)