Skip to content

Commit a8bee9c

Browse files
committed
Implements comments by @aozarov.
1 parent 465f532 commit a8bee9c

6 files changed

Lines changed: 120 additions & 177 deletions

File tree

gcloud-java-dns/src/main/java/com/google/gcloud/dns/AbstractOption.java

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,21 +19,21 @@
1919
import static com.google.common.base.Preconditions.checkNotNull;
2020

2121
import com.google.common.base.MoreObjects;
22-
import com.google.gcloud.spi.DnsServiceRpc;
22+
import com.google.gcloud.spi.DnsRpc;
2323

2424
import java.io.Serializable;
2525
import java.util.Objects;
2626

2727
/**
2828
* A base class for options.
2929
*/
30-
public abstract class AbstractOption implements Serializable {
30+
abstract class AbstractOption implements Serializable {
3131

32-
private static final long serialVersionUID = 201601261704L;
32+
private static final long serialVersionUID = -5912727967831484228L;
3333
private final Object value;
34-
private final DnsServiceRpc.Option rpcOption;
34+
private final DnsRpc.Option rpcOption;
3535

36-
AbstractOption(DnsServiceRpc.Option rpcOption, Object value) {
36+
AbstractOption(DnsRpc.Option rpcOption, Object value) {
3737
this.rpcOption = checkNotNull(rpcOption);
3838
this.value = value;
3939
}
@@ -42,7 +42,7 @@ Object value() {
4242
return value;
4343
}
4444

45-
DnsServiceRpc.Option rpcOption() {
45+
DnsRpc.Option rpcOption() {
4646
return rpcOption;
4747
}
4848

@@ -52,18 +52,19 @@ public boolean equals(Object obj) {
5252
return false;
5353
}
5454
AbstractOption other = (AbstractOption) obj;
55-
return Objects.equals(value, other.value);
55+
return Objects.equals(value, other.value) && Objects.equals(rpcOption, other.rpcOption);
5656
}
5757

5858
@Override
5959
public int hashCode() {
60-
return Objects.hash(value);
60+
return Objects.hash(value, rpcOption);
6161
}
6262

6363
@Override
6464
public String toString() {
6565
return MoreObjects.toStringHelper(this)
6666
.add("value", value)
67+
.add("rpcOption", rpcOption)
6768
.toString();
6869
}
6970
}

0 commit comments

Comments
 (0)