---

Ajay Kannan · Ajay Kannan · commit a8359906525b · 2015-10-21T15:54:39.000-07:00
yaml --- r: 7139 b: refs/heads/tswast-patch-1 c: 6ffe927 h: refs/heads/master i: 7137: 6477e34 7135: 36dea59
diff --git a/[refs] b/[refs]
@@ -57,5 +57,5 @@ refs/tags/v0.18.0: 9d193c4c4b9d1c6f21515dd8e50836b9194ec9bb
 refs/tags/v0.19.0: e67b56e4d8dad5f9a7b38c9b2107c23c828f2ed5
 refs/tags/v0.20.0: 839f7fb7156535146aa1cb2c5aadd8d375d854e8
 refs/tags/v0.20.1: 370471f437f1f4f68a11e068df5cd6bf39edb1fa
-refs/heads/tswast-patch-1: b270c64f96c5cad1e07c717aab1120b10dd7025d
+refs/heads/tswast-patch-1: 6ffe9273596c10d38cef62db73a77b38ac8b8c3c
 refs/heads/pubsub-streaming-pull: 19262b752ee874eb2ca3b950eb2aef44d5a5267b
diff --git a/branches/tswast-patch-1/gcloud-java-datastore/src/main/java/com/google/gcloud/datastore/GqlQuery.java b/branches/tswast-patch-1/gcloud-java-datastore/src/main/java/com/google/gcloud/datastore/GqlQuery.java
@@ -379,12 +379,9 @@ protected void populatePb(com.google.datastore.v1beta3.RunQueryRequest.Builder r
   }
 
   @Override
-  protected StructuredQuery<V> nextQuery(com.google.datastore.v1beta3.RunQueryResponse responsePb) {
-    return new StructuredQuery.Builder<>(type())
-        .namespace(namespace())
-        .mergeFrom(responsePb.getQuery())
-        .prepareNext(responsePb.getBatch())
-        .build();
+  protected Query<V> nextQuery(com.google.datastore.v1beta3.RunQueryResponse responsePb) {
+    return StructuredQuery.<V>fromPb(type(), namespace(), responsePb.getQuery())
+        .nextQuery(responsePb);
   }
 
   @Override
diff --git a/branches/tswast-patch-1/gcloud-java-datastore/src/main/java/com/google/gcloud/datastore/StructuredQuery.java b/branches/tswast-patch-1/gcloud-java-datastore/src/main/java/com/google/gcloud/datastore/StructuredQuery.java
@@ -669,23 +669,9 @@ B mergeFrom(com.google.datastore.v1beta3.Query queryPb) {
       return self();
     }
 
-    B prepareNext(com.google.datastore.v1beta3.QueryResultBatch queryResultBatchPb) {
-      startCursor(new Cursor(queryResultBatchPb.getEndCursor()));
-      if (offset > 0 && queryResultBatchPb.getSkippedResults() < offset) {
-        offset(offset - queryResultBatchPb.getSkippedResults());
-      } else {
-        offset(0);
-        if (limit != null) {
-          limit(limit - queryResultBatchPb.getEntityResultsCount());
-        }
-      }
-      return self();
-    }
-
     public StructuredQuery<V> build() {
       return new StructuredQuery<>(this);
     }
-
   }
 
   static final class Builder<V> extends BaseBuilder<V, Builder<V>> {
@@ -858,8 +844,19 @@ protected void populatePb(com.google.datastore.v1beta3.RunQueryRequest.Builder r
   }
 
   @Override
-  protected StructuredQuery<V> nextQuery(com.google.datastore.v1beta3.RunQueryResponse responsePb) {
-    return new Builder<>(type()).mergeFrom(toPb()).prepareNext(responsePb.getBatch()).build();
+  protected Query<V> nextQuery(com.google.datastore.v1beta3.RunQueryResponse responsePb) {
+    Builder<V> builder = new Builder<>(type());
+    builder.mergeFrom(toPb());
+    builder.startCursor(new Cursor(responsePb.getBatch().getEndCursor()));
+    if (offset > 0 && responsePb.getBatch().getSkippedResults() < offset) {
+      builder.offset(offset - responsePb.getBatch().getSkippedResults());
+    } else {
+      builder.offset(0);
+      if (limit != null) {
+        builder.limit(limit - responsePb.getBatch().getEntityResultsCount());
+      }
+    }
+    return builder.build();
   }
 
   @Override
@@ -907,7 +904,9 @@ protected Object fromPb(ResultType<V> resultType, String namespace, byte[] bytes
     return fromPb(resultType, namespace, com.google.datastore.v1beta3.Query.parseFrom(bytesPb));
   }
 
-  private static StructuredQuery<?> fromPb(ResultType<?> resultType, String namespace,
+  @SuppressWarnings("unchecked")
+  static <V> StructuredQuery<V> fromPb(
+      ResultType<?> resultType, String namespace,
       com.google.datastore.v1beta3.Query queryPb) {
     BaseBuilder<?, ?> builder;
     if (resultType.equals(ResultType.ENTITY)) {
@@ -917,6 +916,6 @@ private static StructuredQuery<?> fromPb(ResultType<?> resultType, String namesp
     } else {
       builder = new ProjectionEntityQueryBuilder();
     }
-    return builder.namespace(namespace).mergeFrom(queryPb).build();
+    return (StructuredQuery<V>) builder.namespace(namespace).mergeFrom(queryPb).build();
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -379,12 +379,9 @@ protected void populatePb(com.google.datastore.v1beta3.RunQueryRequest.Builder r`
`379`	`379`	`}`
`380`	`380`
`381`	`381`	`@Override`
`382`		`- protected StructuredQuery<V> nextQuery(com.google.datastore.v1beta3.RunQueryResponse responsePb) {`
`383`		`- return new StructuredQuery.Builder<>(type())`
`384`		`- .namespace(namespace())`
`385`		`- .mergeFrom(responsePb.getQuery())`
`386`		`- .prepareNext(responsePb.getBatch())`
`387`		`- .build();`
	`382`	`+ protected Query<V> nextQuery(com.google.datastore.v1beta3.RunQueryResponse responsePb) {`
	`383`	`+ return StructuredQuery.<V>fromPb(type(), namespace(), responsePb.getQuery())`
	`384`	`+ .nextQuery(responsePb);`
`388`	`385`	`}`
`389`	`386`
`390`	`387`	`@Override`