Style updates to ResourceManagerRpc

Ajay Kannan · Ajay Kannan · commit a60f7d16050a · 2015-12-21T09:15:57.000-08:00
diff --git a/gcloud-java-resourcemanager/src/main/java/com/google/gcloud/spi/ResourceManagerRpc.java b/gcloud-java-resourcemanager/src/main/java/com/google/gcloud/spi/ResourceManagerRpc.java
@@ -20,6 +20,7 @@
 
 import com.google.api.services.cloudresourcemanager.model.Policy;
 import com.google.api.services.cloudresourcemanager.model.Project;
+import com.google.common.collect.ImmutableList;
 import com.google.gcloud.resourcemanager.ResourceManagerException;
 
 import java.util.Collections;
@@ -34,7 +35,7 @@ public enum Permission {
     LIST,
     UPDATE,
     GET_IAM_POLICY,
-    SET_IAM_POLICY;
+    SET_IAM_POLICY
   }
 
   class Tuple<X, Y> {
@@ -68,7 +69,7 @@ public class ListOptions {
         new ListOptions(Collections.<String>emptyList(), null, -1);
 
     ListOptions(List<String> filters, String pageToken, int pageSize) {
-      this.filters = checkNotNull(filters);
+      this.filters = checkNotNull(ImmutableList.copyOf(filters));
       this.pageToken = pageToken;
       this.pageSize = pageSize;
     }
@@ -105,12 +106,14 @@ public int pageSize() {
 
   void undelete(String projectId) throws ResourceManagerException;
 
-  Project update(String projectId, Project project) throws ResourceManagerException;
+  Project update(Project project) throws ResourceManagerException;
 
   Policy getIamPolicy(String projectId) throws ResourceManagerException;
 
   void setIamPolicy(String projectId, Policy policy) throws ResourceManagerException;
 
   List<Boolean> hasPermissions(String projectId, List<Permission> permissions)
       throws ResourceManagerException;
+
+  // TODO(ajaykannan): implement "Organization" functionality when available
 }
