pr comment

pongad · pongad · commit a0628d27ce99 · 2017-03-15T12:54:48.000+11:00
diff --git a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/MessageDispatcher.java b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/MessageDispatcher.java
@@ -366,7 +366,7 @@ public void run() {
                   * 1000L);
       logger.log(
           Level.FINER,
-          "Running alarm sent outstanding acks, at time: {0}, with cutover time: {1}, padding {2}",
+          "Running alarm sent outstanding acks, at time: {0}, with cutover time: {1}, padding: {2}",
           new Object[] {now, cutOverTime, ackExpirationPadding});
       Instant nextScheduleExpiration = null;
       List<PendingModifyAckDeadline> modifyAckDeadlinesToSend = new ArrayList<>();
diff --git a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/PollingSubscriberConnection.java b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/PollingSubscriberConnection.java
@@ -95,7 +95,7 @@ public PollingSubscriberConnection(
 
   @Override
   protected void doStart() {
-    logger.log(Level.FINE, "Starting subscriber.");
+    logger.config("Starting subscriber.");
     initialize();
     notifyStarted();
   }
diff --git a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/StreamingSubscriberConnection.java b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/StreamingSubscriberConnection.java
@@ -96,7 +96,7 @@ public StreamingSubscriberConnection(
 
   @Override
   protected void doStart() {
-    logger.log(Level.FINE, "Starting subscriber.");
+    logger.config("Starting subscriber.");
     initialize();
     notifyStarted();
   }
@@ -140,7 +140,7 @@ public void onError(Throwable t) {
 
     @Override
     public void onCompleted() {
-      logger.log(Level.FINE, "Streaming pull terminated successfully!");
+      logger.fine("Streaming pull terminated successfully!");
       errorFuture.set(null);
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ public PollingSubscriberConnection(`
`95`	`95`
`96`	`96`	`@Override`
`97`	`97`	`protected void doStart() {`
`98`		`- logger.log(Level.FINE, "Starting subscriber.");`
	`98`	`+ logger.config("Starting subscriber.");`
`99`	`99`	`initialize();`
`100`	`100`	`notifyStarted();`
`101`	`101`	`}`
Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ public StreamingSubscriberConnection(`
`96`	`96`
`97`	`97`	`@Override`
`98`	`98`	`protected void doStart() {`
`99`		`- logger.log(Level.FINE, "Starting subscriber.");`
	`99`	`+ logger.config("Starting subscriber.");`
`100`	`100`	`initialize();`
`101`	`101`	`notifyStarted();`
`102`	`102`	`}`
`@@ -140,7 +140,7 @@ public void onError(Throwable t) {`
`140`	`140`
`141`	`141`	`@Override`
`142`	`142`	`public void onCompleted() {`
`143`		`- logger.log(Level.FINE, "Streaming pull terminated successfully!");`
	`143`	`+ logger.fine("Streaming pull terminated successfully!");`
`144`	`144`	`errorFuture.set(null);`
`145`	`145`	`}`
`146`	`146`	`}`