FireStore:deprecated warnings removed (#5247)

abhinav-qlogic · sduskis · commit 9d9404b35b67 · 2019-06-04T08:25:52.000-04:00
* deprecated warnings removed

* review changes

* directExecutor used to remove deprecated warnings
diff --git a/google-cloud-clients/google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreImpl.java b/google-cloud-clients/google-cloud-firestore/src/main/java/com/google/cloud/firestore/FirestoreImpl.java
@@ -29,6 +29,7 @@
 import com.google.cloud.firestore.spi.v1.FirestoreRpc;
 import com.google.common.base.Preconditions;
 import com.google.common.collect.ImmutableMap;
+import com.google.common.util.concurrent.MoreExecutors;
 import com.google.firestore.v1.BatchGetDocumentsRequest;
 import com.google.firestore.v1.BatchGetDocumentsResponse;
 import com.google.firestore.v1.DatabaseRootName;
@@ -339,9 +340,11 @@ public void onSuccess(List<WriteResult> writeResults) {
                             span.end();
                             resultFuture.set(userResult);
                           }
-                        });
+                        },
+                        MoreExecutors.directExecutor());
                   }
-                });
+                },
+                MoreExecutors.directExecutor());
           }
 
           private SettableApiFuture<T> invokeUserCallback() {
@@ -396,12 +399,14 @@ public void onFailure(Throwable throwable) {
                     public void onSuccess(Void ignored) {
                       resultFuture.setException(throwable);
                     }
-                  });
+                  },
+                  MoreExecutors.directExecutor());
             } else {
               resultFuture.setException(throwable);
             }
           }
-        });
+        },
+        MoreExecutors.directExecutor());
   }
 
   /** Returns whether the user has opted into receiving dates as com.google.cloud.Timestamp. */
diff --git a/google-cloud-clients/google-cloud-firestore/src/main/java/com/google/cloud/firestore/spi/v1/GrpcFirestoreRpc.java b/google-cloud-clients/google-cloud-firestore/src/main/java/com/google/cloud/firestore/spi/v1/GrpcFirestoreRpc.java
@@ -85,7 +85,7 @@ public GrpcFirestoreRpc(final FirestoreOptions options) throws IOException {
           || NoCredentials.getInstance().equals(options.getCredentials())) {
         ManagedChannel managedChannel =
             ManagedChannelBuilder.forTarget(options.getHost())
-                .usePlaintext(true)
+                .usePlaintext()
                 .executor(executor)
                 .build();
         TransportChannel transportChannel = GrpcTransportChannel.create(managedChannel);

Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,7 @@`
`29`	`29`	`import com.google.cloud.firestore.spi.v1.FirestoreRpc;`
`30`	`30`	`import com.google.common.base.Preconditions;`
`31`	`31`	`import com.google.common.collect.ImmutableMap;`
	`32`	`+import com.google.common.util.concurrent.MoreExecutors;`
`32`	`33`	`import com.google.firestore.v1.BatchGetDocumentsRequest;`
`33`	`34`	`import com.google.firestore.v1.BatchGetDocumentsResponse;`
`34`	`35`	`import com.google.firestore.v1.DatabaseRootName;`
`@@ -339,9 +340,11 @@ public void onSuccess(List<WriteResult> writeResults) {`
`339`	`340`	`span.end();`
`340`	`341`	`resultFuture.set(userResult);`
`341`	`342`	`}`
`342`		`- });`
	`343`	`+ },`
	`344`	`+ MoreExecutors.directExecutor());`
`343`	`345`	`}`
`344`		`- });`
	`346`	`+ },`
	`347`	`+ MoreExecutors.directExecutor());`
`345`	`348`	`}`
`346`	`349`
`347`	`350`	`private SettableApiFuture<T> invokeUserCallback() {`
`@@ -396,12 +399,14 @@ public void onFailure(Throwable throwable) {`
`396`	`399`	`public void onSuccess(Void ignored) {`
`397`	`400`	`resultFuture.setException(throwable);`
`398`	`401`	`}`
`399`		`- });`
	`402`	`+ },`
	`403`	`+ MoreExecutors.directExecutor());`
`400`	`404`	`} else {`
`401`	`405`	`resultFuture.setException(throwable);`
`402`	`406`	`}`
`403`	`407`	`}`
`404`		`- });`
	`408`	`+ },`
	`409`	`+ MoreExecutors.directExecutor());`
`405`	`410`	`}`
`406`	`411`
`407`	`412`	`/** Returns whether the user has opted into receiving dates as com.google.cloud.Timestamp. */`