Skip to content

Commit 9bbbe6c

Browse files
author
Ajay Kannan
committed
---
yaml --- r: 6483 b: refs/heads/tswast-patch-1 c: 6c40825 h: refs/heads/master i: 6481: a5fdd36 6479: 43c4607
1 parent 4c43013 commit 9bbbe6c

2 files changed

Lines changed: 7 additions & 4 deletions

File tree

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,5 +57,5 @@ refs/tags/v0.18.0: 9d193c4c4b9d1c6f21515dd8e50836b9194ec9bb
5757
refs/tags/v0.19.0: e67b56e4d8dad5f9a7b38c9b2107c23c828f2ed5
5858
refs/tags/v0.20.0: 839f7fb7156535146aa1cb2c5aadd8d375d854e8
5959
refs/tags/v0.20.1: 370471f437f1f4f68a11e068df5cd6bf39edb1fa
60-
refs/heads/tswast-patch-1: ad12f4143bbcb5d6557055452717c7380cf54959
60+
refs/heads/tswast-patch-1: 6c408256e1621c7e0f3640fb7a4ffdef139f5241
6161
refs/heads/pubsub-streaming-pull: 19262b752ee874eb2ca3b950eb2aef44d5a5267b

branches/tswast-patch-1/gcloud-java-core/src/main/java/com/google/gcloud/ServiceOptions.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
package com.google.gcloud;
1818

1919
import static com.google.common.base.MoreObjects.firstNonNull;
20-
import static com.google.common.base.Preconditions.checkNotNull;
20+
import static com.google.common.base.Preconditions.checkArgument;
2121
import static java.nio.charset.StandardCharsets.UTF_8;
2222

2323
import com.google.api.client.extensions.appengine.http.UrlFetchTransport;
@@ -308,7 +308,10 @@ protected ServiceOptions(Class<? extends ServiceFactory<ServiceT, OptionsT>> ser
308308
Builder<ServiceT, ServiceRpcT, OptionsT, ?> builder) {
309309
projectId = builder.projectId != null ? builder.projectId : defaultProject();
310310
if (projectIdRequired()) {
311-
checkNotNull(projectId);
311+
checkArgument(
312+
projectId != null,
313+
"A project ID is required for this service but could not be determined from the builder or "
314+
+ "the environment. Please set a project ID using the builder.");
312315
}
313316
host = firstNonNull(builder.host, defaultHost());
314317
httpTransportFactory = firstNonNull(builder.httpTransportFactory,
@@ -334,7 +337,7 @@ protected ServiceOptions(Class<? extends ServiceFactory<ServiceT, OptionsT>> ser
334337
*
335338
* @return true if a project ID is required to use the service, false if not.
336339
*/
337-
public boolean projectIdRequired() {
340+
protected boolean projectIdRequired() {
338341
return true;
339342
}
340343

0 commit comments

Comments
 (0)