---

JesseLovelace · chingor13 · commit 98359457c6dd · 2019-05-22T13:51:31.000-07:00
yaml --- r: 29091 b: refs/heads/autosynth-logging c: fff25ba h: refs/heads/master i: 29089: 4783526 29087: f580561
diff --git a/[refs] b/[refs]
@@ -104,7 +104,7 @@ refs/tags/v0.61.0: e4b526656bb1bf5eefd0ee578b7405147821225e
 refs/tags/v0.62.0: bbede7385d48ba08f487bdd29ec10668ace96396
 refs/heads/0.60.0-alpha: 10939381ffe0b8da32db4fe3087c86e3aa7f3e55
 refs/heads/autosynth-dlp: 49572edd157e407b5d979154c583b984e144c79f
-refs/heads/autosynth-logging: 720d90171cd515c21a21f9f8f17d638ff67ec09c
+refs/heads/autosynth-logging: fff25ba885353dd4c9499d9084e4463291c72c9a
 refs/heads/dupes: 3478c5d81fd242d0e985656645a679420a2060c2
 refs/tags/v0.63.0: 94f19b71d40f46b36120e7b9d78a1a3d41bfcbd6
 refs/tags/v0.64.0: 456e8fbd129deced3ca025f239a2d8a82bde1d0a
diff --git a/branches/autosynth-logging/google-cloud-clients/google-cloud-core/src/main/java/com/google/cloud/Identity.java b/branches/autosynth-logging/google-cloud-clients/google-cloud-core/src/main/java/com/google/cloud/Identity.java
@@ -255,7 +255,7 @@ public String strValue() {
    * policy identities to {@code Identity} objects.
    */
   public static Identity valueOf(String identityStr) {
-    String[] info = identityStr.split(":");
+    String[] info = identityStr.split(":", 2);
     Type type = Type.valueOf(CaseFormat.LOWER_CAMEL.to(CaseFormat.UPPER_UNDERSCORE, info[0]));
     if (info.length == 1) {
       return new Identity(type, null);
diff --git a/branches/autosynth-logging/google-cloud-clients/google-cloud-core/src/test/java/com/google/cloud/IdentityTest.java b/branches/autosynth-logging/google-cloud-clients/google-cloud-core/src/test/java/com/google/cloud/IdentityTest.java
@@ -141,16 +141,18 @@ public void testValueOfEmpty() {
     Identity.valueOf("");
   }
 
-  @Test(expected = IllegalArgumentException.class)
-  public void testValueOfThreePart() {
-    Identity.valueOf("a:b:c");
-  }
-
   @Test
   public void testUnrecognizedToString() {
     assertEquals("a:b", Identity.valueOf("a:b").strValue());
   }
 
+  @Test
+  public void testValueOfThreePart() {
+    Identity identity = Identity.valueOf("a:b:c");
+    assertEquals("A", identity.getType().name());
+    assertEquals("b:c", identity.getValue());
+  }
+
   private void compareIdentities(Identity expected, Identity actual) {
     assertEquals(expected, actual);
     assertEquals(expected.getType(), actual.getType());
