Skip to content

Commit 94a4b56

Browse files
authored
Post-release cleanup and fixes (specific to recent repository restructure) (#3290)
1) Fix poms deployment config. 2) Fix documentaiton links in readmes. 3) Update main README (remove `goolge-cloud` metapackage reference). 4) Update `RELEASING.md` to reflect changes. The instructions try to avoid having mysterious scripts running in the release process and also ensures that all disruptive operations (actual release/push) are done explicitly and not somewhere in the middle of a mysterious script. 5) Remove `deploy.sh` and `finalize_release.sh` scripts. 6) Fix few previously broken links (bigquerydatatransfer and compute apidocs links)
1 parent b638435 commit 94a4b56

41 files changed

Lines changed: 118 additions & 97 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

README.md

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ This library supports the following Google Cloud Platform services with clients
3333
- [Cloud Video Intelligence](google-cloud-clients/google-cloud-video-intelligence) (Beta)
3434
- [Stackdriver Trace](google-cloud-clients/google-cloud-trace) (Beta)
3535
- [Text-to-Speech](google-cloud-clients/google-cloud-texttospeech) (Beta)
36+
- [IoT](google-cloud-clients/google-cloud-iot) (Beta)
3637

3738
This library supports the following Google Cloud Platform services with clients at an [Alpha](#versioning) quality level:
3839

@@ -43,6 +44,7 @@ This library supports the following Google Cloud Platform services with clients
4344
- [Cloud Resource Manager](google-cloud-clients/google-cloud-resourcemanager) (Alpha)
4445
- [Cloud Speech](google-cloud-clients/google-cloud-speech) (Alpha)
4546
- [Dialogflow](google-cloud-clients/google-cloud-dialogflow) (Alpha)
47+
- [Web Security Scanner](google-cloud-clients/google-cloud-websecurityscanner) (Alpha)
4648

4749
These libraries are deprecated and no longer receive updates:
4850

@@ -51,32 +53,27 @@ These libraries are deprecated and no longer receive updates:
5153
Quickstart
5254
----------
5355

54-
The easy way to get started is to add the umbrella package which pulls in all of the supported clients as
55-
dependencies. Note that even though the version of the umbrella package is Alpha, the individual clients are
56-
at different support levels (Alpha, Beta, and GA).
56+
To call any of the supported Google Cloud Services simply add a corresponding client library artifact as a dependency to your project. The following instructions use `google-cloud-storage` as an example (specific instructions can be found in the README of each client).
5757

58-
[//]: # ({x-version-update-start:google-cloud:released})
58+
[//]: # ({x-version-update-start:google-cloud-storage:released})
5959
If you are using Maven, add this to your pom.xml file
6060
```xml
6161
<dependency>
6262
<groupId>com.google.cloud</groupId>
63-
<artifactId>google-cloud</artifactId>
64-
<version>0.48.0-alpha</version>
63+
<artifactId>google-cloud-storage</artifactId>
64+
<version>1.30.0</version>
6565
</dependency>
6666
```
6767
If you are using Gradle, add this to your dependencies
6868
```Groovy
69-
compile 'com.google.cloud:google-cloud:0.48.0-alpha'
69+
compile 'com.google.cloud:google-cloud-storage:1.30.0'
7070
```
7171
If you are using SBT, add this to your dependencies
7272
```Scala
73-
libraryDependencies += "com.google.cloud" % "google-cloud" % "0.48.0-alpha"
73+
libraryDependencies += "com.google.cloud" % "google-cloud-storage" % "1.30.0"
7474
```
7575
[//]: # ({x-version-update-end})
7676

77-
It also works just as well to declare a dependency only on the specific clients that you need. See the README of
78-
each client for instructions.
79-
8077
If you're using IntelliJ or Eclipse, you can add client libraries to your project using these IDE plugins:
8178
* [Cloud Tools for IntelliJ](https://cloud.google.com/tools/intellij/docs/client-libraries)
8279
* [Cloud Tools for Eclipse](https://cloud.google.com/eclipse/docs/libraries)
@@ -361,4 +358,4 @@ Apache 2.0 - See [LICENSE] for more information.
361358
362359
[cloud-platform]: https://cloud.google.com/
363360
[cloud-platform-docs]: https://cloud.google.com/docs/
364-
[client-lib-docs]: http://googlecloudplatform.github.io/google-cloud-java/latest/apidocs/
361+
[client-lib-docs]: https://googlecloudplatform.github.io/google-cloud-java/google-cloud-clients/apidocs/index.html

RELEASING.md

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -91,27 +91,27 @@ To push a release version
9191

9292
7. To ensure a clean build, remove *all* Maven targets (including subdirectories not handled by `mvn clean`) by running `rm -rf target */target`.
9393

94-
8. Run `utilities/stage_release.sh`.
95-
This script builds and stages the release artifact on the Maven Central Repository, updates the README.md files with the release version + commits them locally, and finally generates a new site version for the gh-pages branch under a temporary directory named `tmp_gh-pages`. If you haven't run the release process before, it's worth verifying everything; check the staged release on the Sonatype website, and verify that the local commits have the right version updates.
94+
8. Run `python utilities/stage_sites.py`.
95+
This script checks out `gh-pages` branch of the repository, builds the documentation site and javadocs, copies them to the branch and commits it. This script does not push the docs and it must be done manually on the later step. The script assumes that there is no directory called `tmp_gh-pages` in the repository root, remove that directory, if exists, before running the script.
9696

97-
If you experience failures, you may need to:
98-
- repeat the clean step above
99-
- remove the temporary directory created to store docs by running `rm -rf tmp_gh-pages`
100-
- remove staged repositories from Sonatype (to prevent them from being released in subsequent steps): if a staged repository appears [here](https://oss.sonatype.org/#nexus-search;quick~com.google.cloud), remove it by running `mvn nexus-staging:drop`.
97+
9. Check that you are not trying to release a SNAPSHOT build (the artifacts versions do not have "-SNAPSHOT" suffix) and then run `mvn clean deploy -DskipTests=true --settings ~/.m2/settings.xml -P release` command. It will build and deploy artifacts to the staging repository.
10198

102-
9. Run `utilities/finalize_release.sh`.
103-
This script will release the staged artifact on the Maven Central Repository and push the README.md and gh-pages updates to github.
99+
10. Run `mvn nexus-staging:release` to release the artifacts.
104100

105-
10. Publish a release on Github manually.
101+
11. Run `cd tmp_gh-pages && git push && cd ..` to push the previously generated docs (step 8).
102+
103+
12. Run `rm -rf tmp_gh-pages` to remove the generated docs directory from your local machine.
104+
105+
13. Publish a release on Github manually.
106106
Go to the [releases page](https://github.com/GoogleCloudPlatform/google-cloud-java/releases) and open the appropriate release draft. Make sure the "Tag Version" is `vX.Y.Z` and the "Release Title" is `X.Y.Z`, where `X.Y.Z` is the release version as listed in the `pom.xml` files.
107107

108108
Add the commits since the last release into the release draft. Try to group them into sections with related changes. Anything that is a breaking change needs to be marked with `*breaking change*`. Such changes are only allowed for alpha/beta modules and `@BetaApi` features.
109109

110110
Ensure that the format is consistent with previous releases (for an example, see the [0.1.0 release](https://github.com/GoogleCloudPlatform/google-cloud-java/releases/tag/v0.1.0)). After adding any missing updates and reformatting as necessary, publish the draft.
111111

112-
11. Run `python utilities/bump_versions.py next_snapshot patch` to include "-SNAPSHOT" in the current project version (Alternatively, update the versions in `versions.txt` to the correct versions for the next release.). Then, run `python utilities/replace_versions.py` to update the `pom.xml` files. (If you see updates in `README.md` files at this step, you probably did something wrong.)
112+
14. Run `python utilities/bump_versions.py next_snapshot patch` to include "-SNAPSHOT" in the current project version (Alternatively, update the versions in `versions.txt` to the correct versions for the next release.). Then, run `python utilities/replace_versions.py` to update the `pom.xml` files. (If you see updates in `README.md` files at this step, you probably did something wrong.)
113113

114-
13. Create and merge in another PR to reflect the updated project version.
114+
15. Create and merge in another PR to reflect the updated project version.
115115

116116
Improvements
117117
============

google-api-grpc/pom.xml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -686,6 +686,19 @@
686686
</execution>
687687
</executions>
688688
</plugin>
689+
<plugin>
690+
<groupId>org.apache.maven.plugins</groupId>
691+
<artifactId>maven-javadoc-plugin</artifactId>
692+
<version>2.10.3</version>
693+
<executions>
694+
<execution>
695+
<id>attach-javadocs</id>
696+
<goals>
697+
<goal>jar</goal>
698+
</goals>
699+
</execution>
700+
</executions>
701+
</plugin>
689702
</plugins>
690703
</build>
691704
</profile>

google-cloud-clients/google-cloud-bigquery/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,4 +245,4 @@ Apache 2.0 - See [LICENSE] for more information.
245245
[cloud-bigquery]: https://cloud.google.com/bigquery/
246246
[cloud-storage]: https://cloud.google.com/storage/
247247
[bigquery-product-docs]: https://cloud.google.com/bigquery/docs/
248-
[bigquery-client-lib-docs]: https://googlecloudplatform.github.io/google-cloud-java/latest/apidocs/index.html?com/google/cloud/bigquery/package-summary.html
248+
[bigquery-client-lib-docs]: https://googlecloudplatform.github.io/google-cloud-java/google-cloud-clients/apidocs/index.html?com/google/cloud/bigquery/package-summary.html

google-cloud-clients/google-cloud-bigquerydatatransfer/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,4 +115,4 @@ Apache 2.0 - See [LICENSE] for more information.
115115

116116
[cloud-bigquerydatatransfer]: https://cloud.google.com/bigquery/docs/transfer-service-overview
117117
[bigquerydatatransfer-product-docs]: https://cloud.google.com/bigquery/docs/transfer-service-overview
118-
[bigquerydatatransfer-client-lib-docs]: https://googlecloudplatform.github.io/google-cloud-java/latest/apidocs/index.html?com/google/cloud/bigquerydatatransfer/v1/package-summary.html
118+
[bigquerydatatransfer-client-lib-docs]: https://googlecloudplatform.github.io/google-cloud-java/google-cloud-clients/apidocs/index.html?com/google/cloud/bigquery/datatransfer/v1/package-summary.html

google-cloud-clients/google-cloud-bigtable/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,4 +171,4 @@ Apache 2.0 - See [LICENSE] for more information.
171171
[cloud-platform]: https://cloud.google.com/
172172
[cloud-bigtable]: https://cloud.google.com/bigtable/
173173
[bigtable-product-docs]: https://cloud.google.com/bigtable/docs/
174-
[bigtable-client-lib-docs]: https://googlecloudplatform.github.io/google-cloud-java/latest/apidocs/index.html?com/google/cloud/bigtable/package-summary.html
174+
[bigtable-client-lib-docs]: https://googlecloudplatform.github.io/google-cloud-java/google-cloud-clients/apidocs/index.html?com/google/cloud/bigtable/package-summary.html

google-cloud-clients/google-cloud-compute/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,4 +276,4 @@ Apache 2.0 - See [LICENSE] for more information.
276276

277277
[cloud-compute]: https://cloud.google.com/compute/
278278
[compute-product-docs]: https://cloud.google.com/compute/docs/
279-
[compute-client-lib-docs]: https://googlecloudplatform.github.io/google-cloud-java/latest/apidocs/index.html?com/google/cloud/compute/package-summary.html
279+
[compute-client-lib-docs]: https://googlecloudplatform.github.io/google-cloud-java/google-cloud-clients/apidocs/index.html?com/google/cloud/compute/deprecated/package-summary.html

google-cloud-clients/google-cloud-container/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,4 +117,4 @@ Apache 2.0 - See [LICENSE] for more information.
117117
[cloud-container]: https://cloud.google.com/kubernetes-engine/
118118
[cloud-container-quickstart]: https://cloud.google.com/kubernetes-engine/docs/quickstart
119119
[container-product-docs]: https://cloud.google.com/kubernetes-engine/docs/
120-
[container-client-lib-docs]: https://googlecloudplatform.github.io/google-cloud-java/latest/apidocs/index.html?com/google/cloud/container/v1/package-summary.html
120+
[container-client-lib-docs]: https://googlecloudplatform.github.io/google-cloud-java/google-cloud-clients/apidocs/index.html?com/google/cloud/container/v1/package-summary.html

google-cloud-clients/google-cloud-contrib/google-cloud-logging-logback/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Logback appender `com.google.cloud.logging.logback.LoggingAppender` for
77
This library allows you to use [Logback](https://logback.qos.ch/) configuration and the [Slf4j](https://www.slf4j.org/) interface to log via Google Cloud logging.
88

99
- [Homepage](https://googlecloudplatform.github.io/google-cloud-java/)
10-
- [API Documentation](https://googlecloudplatform.github.io/google-cloud-java/apidocs/index.html?com/google/cloud/logging/logback/LoggingAppender.html)
10+
- [API Documentation](https://googlecloudplatform.github.io/google-cloud-java/google-cloud-clients/apidocs/index.html?com/google/cloud/logging/logback/LoggingAppender.html)
1111

1212
> Note: This client is a work-in-progress, and may occasionally
1313
> make backwards-incompatible changes.

google-cloud-clients/google-cloud-dataproc/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,5 +117,5 @@ Apache 2.0 - See [LICENSE] for more information.
117117
[cloud-dataproc]: https://cloud.google.com/dataproc/
118118
[cloud-dataproc-quickstart]: https://cloud.google.com/dataproc/quickstart-console#before-you-begin
119119
[dataproc-product-docs]: https://cloud.google.com/dataproc/docs/
120-
[dataproc-client-lib-docs]: https://googlecloudplatform.github.io/google-cloud-java/latest/apidocs/index.html?com/google/cloud/dataproc/v1/package-summary.html
120+
[dataproc-client-lib-docs]: https://googlecloudplatform.github.io/google-cloud-java/google-cloud-clients/apidocs/index.html?com/google/cloud/dataproc/v1/package-summary.html
121121
[auth]: https://cloud.google.com/docs/authentication/getting-started

0 commit comments

Comments
 (0)