Enhancing Publisher.OutstandingBatch (#5007)

sduskis · web-flow · commit 909b0e8ef2d8 · 2019-04-25T11:03:56.000-04:00
- Moving responsibility for creating the SettableFuture into OutstandingBatch
- Moving responsibility for tracking message size into OutstandingBatch
diff --git a/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java b/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java
@@ -197,23 +197,22 @@ public ApiFuture<String> publish(PubsubMessage message) {
     }
 
     message = messageTransform.apply(message);
-    final int messageSize = message.getSerializedSize();
     OutstandingBatch batchToSend = null;
-    SettableApiFuture<String> publishResult = SettableApiFuture.<String>create();
-    final OutstandingPublish outstandingPublish = new OutstandingPublish(publishResult, message);
+    final OutstandingPublish outstandingPublish = new OutstandingPublish(message);
     messagesBatchLock.lock();
     try {
       // Check if the next message makes the current batch exceed the max batch byte size.
       if (!messagesBatch.isEmpty()
           && hasBatchingBytes()
-          && messagesBatch.getBatchedBytes() + messageSize >= getMaxBatchBytes()) {
+          && messagesBatch.getBatchedBytes() + outstandingPublish.messageSize
+              >= getMaxBatchBytes()) {
         batchToSend = messagesBatch.popOutstandingBatch();
       }
 
       // Border case if the message to send is greater or equals to the max batch size then can't
       // be included in the current batch and instead sent immediately.
-      if (!hasBatchingBytes() || messageSize < getMaxBatchBytes()) {
-        messagesBatch.addMessage(outstandingPublish, messageSize);
+      if (!hasBatchingBytes() || outstandingPublish.messageSize < getMaxBatchBytes()) {
+        messagesBatch.addMessage(outstandingPublish, outstandingPublish.messageSize);
 
         // If after adding the message we have reached the batch max messages then we have a batch
         // to send.
@@ -243,20 +242,21 @@ public void run() {
 
     // If the message is over the size limit, it was not added to the pending messages and it will
     // be sent in its own batch immediately.
-    if (hasBatchingBytes() && messageSize >= getMaxBatchBytes()) {
+    if (hasBatchingBytes() && outstandingPublish.messageSize >= getMaxBatchBytes()) {
       logger.log(
           Level.FINER, "Message exceeds the max batch bytes, scheduling it for immediate send.");
       executor.execute(
           new Runnable() {
             @Override
             public void run() {
               publishOutstandingBatch(
-                  new OutstandingBatch(ImmutableList.of(outstandingPublish), messageSize));
+                  new OutstandingBatch(
+                      ImmutableList.of(outstandingPublish), outstandingPublish.messageSize));
             }
           });
     }
 
-    return publishResult;
+    return outstandingPublish.publishResult;
   }
 
   private void setupAlarm() {
@@ -382,12 +382,14 @@ public int size() {
   }
 
   private static final class OutstandingPublish {
-    SettableApiFuture<String> publishResult;
-    PubsubMessage message;
+    final SettableApiFuture<String> publishResult;
+    final PubsubMessage message;
+    final int messageSize;
 
-    OutstandingPublish(SettableApiFuture<String> publishResult, PubsubMessage message) {
-      this.publishResult = publishResult;
+    OutstandingPublish(PubsubMessage message) {
+      this.publishResult = SettableApiFuture.create();
       this.message = message;
+      this.messageSize = message.getSerializedSize();
     }
   }
 
