Fix Codacy problems (unused param, unused local)

skrulcik · skrulcik · commit 8a2f4133e4d8 · 2017-07-20T20:53:16.000-04:00
diff --git a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/Mutation.java b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/Mutation.java
@@ -213,7 +213,7 @@ private void checkBindingInProgress(boolean expectInProgress) {
 
     private void checkDuplicateColumns(ImmutableList<String> columnNames) {
       Set<String> columnNameSet = new HashSet<>();
-      for (String columnName : columns.build()) {
+      for (String columnName : columnNames) {
         columnName = columnName.toLowerCase();
         if (columnNameSet.contains(columnName)) {
           throw new IllegalStateException("Duplicate column: " + columnName);
diff --git a/google-cloud-spanner/src/test/java/com/google/cloud/spanner/MutationTest.java b/google-cloud-spanner/src/test/java/com/google/cloud/spanner/MutationTest.java
@@ -126,14 +126,14 @@ public void replace() {
   public void duplicateColumn() {
     expectedException.expect(IllegalStateException.class);
     expectedException.expectMessage("Duplicate column");
-    Mutation m = Mutation.newInsertBuilder("T1").set("C1").to(true).set("C1").to(false).build();
+    Mutation.newInsertBuilder("T1").set("C1").to(true).set("C1").to(false).build();
   }
 
   @Test
   public void duplicateColumnCaseInsensitive() {
     expectedException.expect(IllegalStateException.class);
     expectedException.expectMessage("Duplicate column");
-    Mutation m = Mutation.newInsertBuilder("T1").set("C1").to(true).set("c1").to(false).build();
+    Mutation.newInsertBuilder("T1").set("C1").to(true).set("c1").to(false).build();
   }
 
   @Test
