pr comment

pongad · pongad · commit 89bfd55badfd · 2017-05-18T09:58:36.000+10:00
diff --git a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Subscriber.java b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Subscriber.java
@@ -432,6 +432,7 @@ public static final class Builder {
     private static final Duration MIN_ACK_EXPIRATION_PADDING = Duration.ofMillis(100);
     private static final Duration DEFAULT_ACK_EXPIRATION_PADDING = Duration.ofMillis(500);
     private static final Duration DEFAULT_MAX_ACK_EXTENSION_PERIOD = Duration.ofMinutes(60);
+    private static final long DEFAULT_MEMORY_PERCENTAGE = 20;
 
     static final ExecutorProvider DEFAULT_EXECUTOR_PROVIDER =
         InstantiatingExecutorProvider.newBuilder()
@@ -449,7 +450,8 @@ public static final class Builder {
 
     FlowControlSettings flowControlSettings =
         FlowControlSettings.newBuilder()
-            .setMaxOutstandingRequestBytes(Runtime.getRuntime().maxMemory() / 5)
+            .setMaxOutstandingRequestBytes(
+                Runtime.getRuntime().maxMemory() * DEFAULT_MEMORY_PERCENTAGE / 100L)
             .build();
 
     ExecutorProvider executorProvider = DEFAULT_EXECUTOR_PROVIDER;
