Skip to content

Commit 8984152

Browse files
danielcomptonandreamlin
authored andcommitted
---
yaml --- r: 8903 b: refs/heads/lesv-patch-1 c: 90db468 h: refs/heads/master i: 8901: fd29257 8899: b1449d2 8895: 95a8b8e
1 parent ad897a9 commit 8984152

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

  • branches/lesv-patch-1/google-cloud-storage/src/main/java/com/google/cloud/storage

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ refs/tags/v0.22.0: 18b298fe4bfe8ec2f20b0e0bf7ffdcce5cc3c5fe
6666
refs/heads/vam-google-patch-1: d0c8fee3a4074d0bf7360ce8c4f7f7223d0ee7b9
6767
refs/heads/vam-google-patch-CODEOWNERS: 2ac1616e25229e51d08a984708ef1918f91a35ee
6868
refs/heads/danoscarmike-patch-1: 7342a9916bce4ed00002c7202e2a16c5d46afaea
69-
refs/heads/lesv-patch-1: ef1ccd0c55a739a46483f604736e54df77eb9bd9
69+
refs/heads/lesv-patch-1: 90db468b0d70701926f4e406215e440d1be29f03
7070
refs/heads/ml-update-branch: 079dd6610017f5c51b9d1938c12d6d55b61513cf
7171
refs/heads/vkedia-patch-2: 7d8241388a9769a5c069334761b06c7012c878e7
7272
refs/heads/vkedia-patch-3: 4d128043acaa7db9160faf439d2ca6104e8a88cb

branches/lesv-patch-1/google-cloud-storage/src/main/java/com/google/cloud/storage/Storage.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -893,7 +893,8 @@ Object getValue() {
893893
}
894894

895895
/**
896-
* The HTTP method to be used with the signed URL.
896+
* The HTTP method to be used with the signed URL.
897+
* If this method is not called, defaults to GET.
897898
*/
898899
public static SignUrlOption httpMethod(HttpMethod httpMethod) {
899900
return new SignUrlOption(Option.HTTP_METHOD, httpMethod.name());
@@ -902,6 +903,7 @@ public static SignUrlOption httpMethod(HttpMethod httpMethod) {
902903
/**
903904
* Use it if signature should include the blob's content-type.
904905
* When used, users of the signed URL should include the blob's content-type with their request.
906+
* If using this URL from a browser, you must include a content type that matches what the browser will send.
905907
*/
906908
public static SignUrlOption withContentType() {
907909
return new SignUrlOption(Option.CONTENT_TYPE, true);

0 commit comments

Comments
 (0)