Skip to content

Commit 8048d02

Browse files
committed
rename MessagesProcessor to MessageDispatcher
Fixes #1546
1 parent 5593253 commit 8048d02

4 files changed

Lines changed: 12 additions & 12 deletions

File tree

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/MessagesProcessor.java renamed to google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/MessageDispatcher.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@
5252
* Dispatches messages to a message receiver while handling the messages acking and lease
5353
* extensions.
5454
*/
55-
class MessagesProcessor {
56-
private static final Logger logger = LoggerFactory.getLogger(MessagesProcessor.class);
55+
class MessageDispatcher {
56+
private static final Logger logger = LoggerFactory.getLogger(MessageDispatcher.class);
5757

5858
private static final int INITIAL_ACK_DEADLINE_EXTENSION_SECONDS = 2;
5959
@VisibleForTesting static final Duration PENDING_ACKS_SEND_DELAY = Duration.millis(100);
@@ -202,7 +202,7 @@ void sendAckOperations(
202202
List<String> acksToSend, List<PendingModifyAckDeadline> ackDeadlineExtensions);
203203
}
204204

205-
MessagesProcessor(
205+
MessageDispatcher(
206206
MessageReceiver receiver,
207207
AcksProcessor acksProcessor,
208208
Duration ackExpirationPadding,

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/PollingSubscriberConnection.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
import com.google.api.stats.Distribution;
2323
import com.google.auth.Credentials;
2424
import com.google.cloud.Clock;
25-
import com.google.cloud.pubsub.MessagesProcessor.AcksProcessor;
26-
import com.google.cloud.pubsub.MessagesProcessor.PendingModifyAckDeadline;
25+
import com.google.cloud.pubsub.MessageDispatcher.AcksProcessor;
26+
import com.google.cloud.pubsub.MessageDispatcher.PendingModifyAckDeadline;
2727
import com.google.cloud.pubsub.Subscriber.MessageReceiver;
2828
import com.google.common.collect.Lists;
2929
import com.google.common.util.concurrent.AbstractService;
@@ -64,7 +64,7 @@ final class PollingSubscriberConnection extends AbstractService implements AcksP
6464
private final String subscription;
6565
private final ScheduledExecutorService executor;
6666
private final SubscriberFutureStub stub;
67-
private final MessagesProcessor messagesProcessor;
67+
private final MessageDispatcher messagesProcessor;
6868

6969
public PollingSubscriberConnection(
7070
String subscription,
@@ -82,7 +82,7 @@ public PollingSubscriberConnection(
8282
SubscriberGrpc.newFutureStub(channel)
8383
.withCallCredentials(MoreCallCredentials.from(credentials));
8484
messagesProcessor =
85-
new MessagesProcessor(
85+
new MessageDispatcher(
8686
receiver,
8787
this,
8888
ackExpirationPadding,

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/StreamingSubscriberConnection.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
import com.google.api.stats.Distribution;
2323
import com.google.auth.Credentials;
2424
import com.google.cloud.Clock;
25-
import com.google.cloud.pubsub.MessagesProcessor.AcksProcessor;
26-
import com.google.cloud.pubsub.MessagesProcessor.PendingModifyAckDeadline;
25+
import com.google.cloud.pubsub.MessageDispatcher.AcksProcessor;
26+
import com.google.cloud.pubsub.MessageDispatcher.PendingModifyAckDeadline;
2727
import com.google.cloud.pubsub.Subscriber.MessageReceiver;
2828
import com.google.common.collect.Lists;
2929
import com.google.common.util.concurrent.AbstractService;
@@ -63,7 +63,7 @@ final class StreamingSubscriberConnection extends AbstractService implements Ack
6363

6464
private final String subscription;
6565
private final ScheduledExecutorService executor;
66-
private final MessagesProcessor messagesProcessor;
66+
private final MessageDispatcher messagesProcessor;
6767
private ClientCallStreamObserver<StreamingPullRequest> requestObserver;
6868

6969
public StreamingSubscriberConnection(
@@ -82,7 +82,7 @@ public StreamingSubscriberConnection(
8282
this.credentials = credentials;
8383
this.channel = channel;
8484
this.messagesProcessor =
85-
new MessagesProcessor(
85+
new MessageDispatcher(
8686
receiver,
8787
this,
8888
ackExpirationPadding,

google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/SubscriberImplTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
package com.google.cloud.pubsub;
1818

19-
import static com.google.cloud.pubsub.MessagesProcessor.PENDING_ACKS_SEND_DELAY;
19+
import static com.google.cloud.pubsub.MessageDispatcher.PENDING_ACKS_SEND_DELAY;
2020
import static org.junit.Assert.assertEquals;
2121

2222
import com.google.cloud.pubsub.FakeSubscriberServiceImpl.ModifyAckDeadline;

0 commit comments

Comments
 (0)