Fix ApiFutures.addCallback() (#3886)

anguillanneuf · pongad · commit 7d507997ffc1 · 2018-11-05T15:36:27.000-08:00
ApiFutures.addCallback() now requires a third argument (a non-direct executor). Ref: https://github.com/googleapis/api-common-java/blob/master/src/main/java/com/google/api/core/ApiFutures.java
diff --git a/google-cloud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/PublisherSnippets.java b/google-cloud-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/PublisherSnippets.java
@@ -36,6 +36,7 @@
 import com.google.pubsub.v1.ProjectTopicName;
 import com.google.pubsub.v1.PubsubMessage;
 import java.io.FileInputStream;
+import java.util.concurrent.Executors;
 import java.util.concurrent.TimeUnit;
 import org.threeten.bp.Duration;
 
@@ -62,7 +63,7 @@ public void onSuccess(String messageId) {
       public void onFailure(Throwable t) {
         System.out.println("failed to publish: " + t);
       }
-    });
+    }, Executors.newSingleThreadExecutor());
     return messageIdFuture;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,7 @@`
`36`	`36`	`import com.google.pubsub.v1.ProjectTopicName;`
`37`	`37`	`import com.google.pubsub.v1.PubsubMessage;`
`38`	`38`	`import java.io.FileInputStream;`
	`39`	`+import java.util.concurrent.Executors;`
`39`	`40`	`import java.util.concurrent.TimeUnit;`
`40`	`41`	`import org.threeten.bp.Duration;`
`41`	`42`
`@@ -62,7 +63,7 @@ public void onSuccess(String messageId) {`
`62`	`63`	`public void onFailure(Throwable t) {`
`63`	`64`	`System.out.println("failed to publish: " + t);`
`64`	`65`	`}`
`65`		`- });`
	`66`	`+ }, Executors.newSingleThreadExecutor());`
`66`	`67`	`return messageIdFuture;`
`67`	`68`	`}`
`68`	`69`