Skip to content

Commit 7bcd312

Browse files
shollymansduskis
authored andcommitted
---
yaml --- r: 34973 b: refs/heads/autosynth-trace c: 5f045ef h: refs/heads/master i: 34971: aa57dae
1 parent 2e67e14 commit 7bcd312

3 files changed

Lines changed: 3 additions & 13 deletions

File tree

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ refs/heads/autosynth-spanner: d963fe4368e79cf6abae5d511785e8ced8ac57f4
141141
refs/heads/autosynth-speech: c563dcd420cce0a37c39b1b9c24be1b9ba604dc7
142142
refs/heads/autosynth-tasks: 25d1eafe8cb66b00e3dad765dac74a5b45b83e63
143143
refs/heads/autosynth-texttospeech: 7a3ad430dddaed7a76f2026064502680c9339915
144-
refs/heads/autosynth-trace: 7f07a1adf7c6adaed14791fa1f059bdc7284571a
144+
refs/heads/autosynth-trace: 5f045ef212c60e819c6d5ba374b838036a19441b
145145
refs/heads/autosynth-websecurityscanner: fa561b356aabcd92d415ae8dc88fd8d87dbc5b23
146146
refs/heads/bigquerystorage: 06db74d123d7f8a3ef48755c2fcabed09faf8e64
147147
refs/heads/elharo-patch-1: ce159ef828d3c545991ff78e7b6e0d912a9453e9

branches/autosynth-trace/google-cloud-clients/google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1beta1/stub/EnhancedBigQueryStorageStubSettingsTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ public void testCreateReadSessionSettings() {
120120
public void testReadRowsSettings() {
121121
ServerStreamingCallSettings.Builder<ReadRowsRequest, ReadRowsResponse> builder =
122122
EnhancedBigQueryStorageStubSettings.newBuilder().readRowsSettings();
123-
assertThat(builder.getRetryableCodes()).containsAllOf(Code.DEADLINE_EXCEEDED, Code.UNAVAILABLE);
123+
assertThat(builder.getRetryableCodes()).contains(Code.UNAVAILABLE);
124124
RetrySettings retrySettings = builder.getRetrySettings();
125125
assertThat(retrySettings.getInitialRetryDelay()).isEqualTo(Duration.ofMillis(100L));
126126
assertThat(retrySettings.getRetryDelayMultiplier()).isWithin(1e-6).of(1.3);
@@ -157,7 +157,7 @@ public void testSplitReadStreamSettings() {
157157
}
158158

159159
private void verifyRetrySettings(Set<Code> retryCodes, RetrySettings retrySettings) {
160-
assertThat(retryCodes).containsAllOf(Code.DEADLINE_EXCEEDED, Code.UNAVAILABLE);
160+
assertThat(retryCodes).contains(Code.UNAVAILABLE);
161161
assertThat(retrySettings.getTotalTimeout()).isGreaterThan(Duration.ZERO);
162162
assertThat(retrySettings.getInitialRetryDelay()).isGreaterThan(Duration.ZERO);
163163
assertThat(retrySettings.getRetryDelayMultiplier()).isAtLeast(1.0);

branches/autosynth-trace/google-cloud-clients/google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1beta1/stub/readrows/ReadRowsRetryTest.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -112,11 +112,6 @@ public void multipleRetryTestWithZeroInitialOffset() {
112112
.respondWithNumberOfRows(5)
113113
.respondWithStatus(Code.UNAVAILABLE));
114114

115-
service.expectations.add(
116-
RpcExpectation.create()
117-
.expectRequest("fake-stream", 5)
118-
.respondWithStatus(Code.DEADLINE_EXCEEDED));
119-
120115
service.expectations.add(
121116
RpcExpectation.create()
122117
.expectRequest("fake-stream", 5)
@@ -139,11 +134,6 @@ public void multipleRetryTestWithNonZeroInitialOffset() {
139134
.respondWithNumberOfRows(5)
140135
.respondWithStatus(Code.UNAVAILABLE));
141136

142-
service.expectations.add(
143-
RpcExpectation.create()
144-
.expectRequest("fake-stream", 22)
145-
.respondWithStatus(Code.DEADLINE_EXCEEDED));
146-
147137
service.expectations.add(
148138
RpcExpectation.create()
149139
.expectRequest("fake-stream", 22)

0 commit comments

Comments
 (0)