---

sduskis · web-flow · commit 761d384237c3 · 2019-02-07T20:52:13.000-05:00
yaml --- r: 18143 b: refs/heads/pubsub-ordering-keys c: 1baa602 h: refs/heads/master i: 18141: a859960 18139: bef4033 18135: 603cae8 18127: 7905725 18111: 1cbd452
diff --git a/[refs] b/[refs]
@@ -159,7 +159,7 @@ refs/tags/v0.72.0: a7703f2593ba312c0b2dde6fdfd4f5c764bb55ac
 refs/tags/v0.73.0: 21241ea8be9439cc5764c4944cdce21d34ce4f9e
 refs/tags/v0.74.0: 9d1f733dbbf790de7b494418523b69c4a9a57638
 refs/heads/ignoretest: 23c412ae07af3d0ab1caa2d44d5bc5c0ccb8b31d
-refs/heads/pubsub-ordering-keys: 81bdd008363130086ab4a328e28bfbe13ede8ed3
+refs/heads/pubsub-ordering-keys: 1baa6023966a694c1ccd8ed8d5b47ece662b4fce
 "refs/heads/update_mvn_badge": ae2d773814db0f71197ccf5a8612ee1d8056f8de
 refs/tags/v0.75.0: c3673089ae09a897c1b4cf7dfe167fe4f8ab32fb
 refs/tags/v0.76.0: 395b016826d3ddf9cb8b34919636df15a4dbd032
diff --git a/branches/pubsub-ordering-keys/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/Mutation.java b/branches/pubsub-ordering-keys/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/Mutation.java
@@ -73,6 +73,19 @@ public static Mutation createUnsafe() {
     return new Mutation(true);
   }
 
+  /**
+   * Wraps the List of protobuf {@link com.google.bigtable.v2.Mutation}. This methods, like {@link
+   * #createUnsafe()}, allows setCell operation to use server side timestamp. This is dangerous
+   * because mutations will no longer be idempotent, which might cause multiple duplicate values to
+   * be stored in Bigtable. This option should only be used for advanced usecases with extreme care.
+   */
+  @BetaApi
+  public static Mutation fromProtoUnsafe(List<com.google.bigtable.v2.Mutation> protos) {
+    Mutation mutation = new Mutation(true);
+    mutation.mutations.addAll(protos);
+    return mutation;
+  }
+
   private Mutation(boolean allowServersideTimestamp) {
     this.allowServersideTimestamp = allowServersideTimestamp;
   }
diff --git a/branches/pubsub-ordering-keys/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/models/MutationTest.java b/branches/pubsub-ordering-keys/google-cloud-clients/google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/models/MutationTest.java
@@ -95,6 +95,8 @@ public void setCellTest() {
     assertThat(actual.get(3).getSetCell().getValue())
         .isEqualTo(ByteString.copyFromUtf8("fake-value2"));
     assertThat(actual.get(3).getSetCell().getTimestampMicros()).isIn(expectedTimestampRange);
+
+    assertThat(Mutation.fromProtoUnsafe(actual).getMutations()).isEqualTo(actual);
   }
 
   @Test

Original file line number	Diff line number	Diff line change
`@@ -95,6 +95,8 @@ public void setCellTest() {`
`95`	`95`	`assertThat(actual.get(3).getSetCell().getValue())`
`96`	`96`	`.isEqualTo(ByteString.copyFromUtf8("fake-value2"));`
`97`	`97`	`assertThat(actual.get(3).getSetCell().getTimestampMicros()).isIn(expectedTimestampRange);`
	`98`	`+`
	`99`	`+ assertThat(Mutation.fromProtoUnsafe(actual).getMutations()).isEqualTo(actual);`
`98`	`100`	`}`
`99`	`101`
`100`	`102`	`@Test`