pr comment

pongad · pongad · commit 742e94746215 · 2017-05-11T15:16:48.000+10:00
diff --git a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Subscriber.java b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Subscriber.java
@@ -409,8 +409,9 @@ private void stopConnections(List<? extends ApiService> connections) {
       try {
         subscriber.awaitTerminated();
       } catch (IllegalStateException e) {
-        // It is expected for some connections to be already in state failed so stop will
-        // throw this expection.
+        // If the service fails, awaitTerminated will throw an exception.
+        // However, we could be stopping services because at least one
+        // has already failed, so we just ignore this exception.
       }
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -409,8 +409,9 @@ private void stopConnections(List<? extends ApiService> connections) {`
`409`	`409`	`try {`
`410`	`410`	`subscriber.awaitTerminated();`
`411`	`411`	`} catch (IllegalStateException e) {`
`412`		`- // It is expected for some connections to be already in state failed so stop will`
`413`		`- // throw this expection.`
	`412`	`+ // If the service fails, awaitTerminated will throw an exception.`
	`413`	`+ // However, we could be stopping services because at least one`
	`414`	`+ // has already failed, so we just ignore this exception.`
`414`	`415`	`}`
`415`	`416`	`}`
`416`	`417`	`}`