---

mziccard · mziccard · commit 72e26e0da4f0 · 2015-11-07T23:50:45.000+01:00
yaml --- r: 6471 b: refs/heads/tswast-patch-1 c: 076127d h: refs/heads/master i: 6469: 02e57d6 6467: acacce0 6463: 3fce4c3
diff --git a/[refs] b/[refs]
@@ -57,5 +57,5 @@ refs/tags/v0.18.0: 9d193c4c4b9d1c6f21515dd8e50836b9194ec9bb
 refs/tags/v0.19.0: e67b56e4d8dad5f9a7b38c9b2107c23c828f2ed5
 refs/tags/v0.20.0: 839f7fb7156535146aa1cb2c5aadd8d375d854e8
 refs/tags/v0.20.1: 370471f437f1f4f68a11e068df5cd6bf39edb1fa
-refs/heads/tswast-patch-1: 7a723996f7c352fd93ceae91f41e474de256873d
+refs/heads/tswast-patch-1: 076127d6ce599716519eeffd5595fe8c5313b5df
 refs/heads/pubsub-streaming-pull: 19262b752ee874eb2ca3b950eb2aef44d5a5267b
diff --git a/branches/tswast-patch-1/gcloud-java-core/src/main/java/com/google/gcloud/PageImpl.java b/branches/tswast-patch-1/gcloud-java-core/src/main/java/com/google/gcloud/PageImpl.java
@@ -50,18 +50,14 @@ static class PageIterator<T> extends AbstractIterator<T> {
 
     @Override
     protected T computeNext() {
-      if (currentPageIterator.hasNext()) {
-        return currentPageIterator.next();
-      }
-      Page<T> nextPage = currentPage.nextPage();
-      if (nextPage != null) {
-        currentPage = nextPage;
-        currentPageIterator = currentPage.values().iterator();
-        if (currentPageIterator.hasNext()) {
-          return currentPageIterator.next();
+      while (!currentPageIterator.hasNext()) {
+        currentPage = currentPage.nextPage();
+        if (currentPage == null) {
+          return endOfData();
         }
+        currentPageIterator = currentPage.values().iterator();
       }
-      return endOfData();
+      return currentPageIterator.next();
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -50,18 +50,14 @@ static class PageIterator<T> extends AbstractIterator<T> {`
`50`	`50`
`51`	`51`	`@Override`
`52`	`52`	`protected T computeNext() {`
`53`		`- if (currentPageIterator.hasNext()) {`
`54`		`- return currentPageIterator.next();`
`55`		`- }`
`56`		`- Page<T> nextPage = currentPage.nextPage();`
`57`		`- if (nextPage != null) {`
`58`		`- currentPage = nextPage;`
`59`		`- currentPageIterator = currentPage.values().iterator();`
`60`		`- if (currentPageIterator.hasNext()) {`
`61`		`- return currentPageIterator.next();`
	`53`	`+ while (!currentPageIterator.hasNext()) {`
	`54`	`+ currentPage = currentPage.nextPage();`
	`55`	`+ if (currentPage == null) {`
	`56`	`+ return endOfData();`
`62`	`57`	`}`
	`58`	`+ currentPageIterator = currentPage.values().iterator();`
`63`	`59`	`}`
`64`		`- return endOfData();`
	`60`	`+ return currentPageIterator.next();`
`65`	`61`	`}`
`66`	`62`	`}`
`67`	`63`