pr comment

pongad · pongad · commit 72316dc56433 · 2017-03-14T11:46:18.000+11:00
diff --git a/google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingHandler.java b/google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingHandler.java
@@ -70,7 +70,7 @@
  *     handler (defaults to {@code Level.INFO}).
  *     <p> This configuration also sets the "base severity level".
  *     Logs with the same severity with the base could be more efficiently sent to Stackdriver.
- *     The base severity defaults to the level of of handler or {@code Level.FINEST}
+ *     The base severity defaults to the level of the handler or {@code Level.FINEST}
  *     if the handler is set to {@code Level.ALL}.
  *     There is currently no way to modify the base level, see
  *     <a href="https://github.com/GoogleCloudPlatform/google-cloud-java/issues/1740">tracking issue</a>.
diff --git a/google-cloud-logging/src/test/java/com/google/cloud/logging/LoggingHandlerTest.java b/google-cloud-logging/src/test/java/com/google/cloud/logging/LoggingHandlerTest.java
@@ -147,14 +147,14 @@ public class LoggingHandlerTest {
           .put("resourceType", "testResourceType")
           .put("synchronicity", "SYNC")
           .build();
-  private static final ImmutableMap<String, String> NATIVE_SEVERITY_MAP =
+  private static final ImmutableMap<String, String> BASE_SEVERITY_MAP =
       ImmutableMap.of(
           "levelName", Level.INFO.getName(), "levelValue", String.valueOf(Level.INFO.intValue()));
   private static final WriteOption[] DEFAULT_OPTIONS =
       new WriteOption[] {
         WriteOption.logName(LOG_NAME),
         WriteOption.resource(DEFAULT_RESOURCE),
-        WriteOption.labels(NATIVE_SEVERITY_MAP)
+        WriteOption.labels(BASE_SEVERITY_MAP)
       };
 
   private static byte[] renderConfig(Map<String, String> config) {
@@ -277,7 +277,7 @@ public void testPublishCustomResource() {
         ImmutableList.of(FINEST_ENTRY),
         WriteOption.logName(LOG_NAME),
         WriteOption.resource(resource),
-        WriteOption.labels(NATIVE_SEVERITY_MAP));
+        WriteOption.labels(BASE_SEVERITY_MAP));
     EasyMock.expectLastCall().andReturn(ApiFutures.immediateFuture(null));
     EasyMock.replay(options, logging);
     Handler handler = new LoggingHandler(LOG_NAME, options, resource);
@@ -295,7 +295,7 @@ public void testEnhancedLogEntry() {
         ImmutableList.of(FINEST_ENHANCED_ENTRY),
         WriteOption.logName(LOG_NAME),
         WriteOption.resource(resource),
-        WriteOption.labels(NATIVE_SEVERITY_MAP));
+        WriteOption.labels(BASE_SEVERITY_MAP));
     EasyMock.expectLastCall().andReturn(ApiFutures.immediateFuture(null));
     EasyMock.replay(options, logging);
     LoggingHandler.Enhancer enhancer = new LoggingHandler.Enhancer() {
