Refactoring SequentialExecutorService.java (#4979)

sduskis · web-flow · commit 708d7850d6c8 · 2019-04-18T11:24:21.000-04:00
- Marking methods as private
- renaming variables from `finalTasks` to `tasks` for clarity
- reducing code duplication by calling `execute`
diff --git a/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/SequentialExecutorService.java b/google-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/SequentialExecutorService.java
@@ -115,17 +115,17 @@ private static class AutoExecutor extends SequentialExecutor {
       super(executor);
     }
 
-    protected void execute(final String key, final Deque<Runnable> finalTasks) {
+    protected void execute(final String key, final Deque<Runnable> tasks) {
       executor.execute(
           new Runnable() {
             @Override
             public void run() {
-              invokeCallbackAndExecuteNext(key, finalTasks);
+              invokeCallbackAndExecuteNext(key, tasks);
             }
           });
     }
 
-    protected void invokeCallbackAndExecuteNext(final String key, final Deque<Runnable> tasks) {
+    private void invokeCallbackAndExecuteNext(final String key, final Deque<Runnable> tasks) {
       invokeCallback(tasks);
       synchronized (tasksByKey) {
         if (tasks.isEmpty()) {
@@ -137,13 +137,7 @@ protected void invokeCallbackAndExecuteNext(final String key, final Deque<Runnab
           return;
         }
       }
-      executor.execute(
-          new Runnable() {
-            @Override
-            public void run() {
-              invokeCallbackAndExecuteNext(key, tasks);
-            }
-          });
+      execute(key, tasks);
     }
   }
 
@@ -199,18 +193,18 @@ public void cancel(Throwable e) {
       return future;
     }
 
-    protected void execute(final String key, final Deque<Runnable> finalTasks) {
+    protected void execute(final String key, final Deque<Runnable> tasks) {
       executor.execute(
           new Runnable() {
             @Override
             public void run() {
-              invokeCallback(finalTasks);
+              invokeCallback(tasks);
             }
           });
     }
 
     /** Executes the next queued task associated with {@code key}. */
-    void resume(final String key) {
+    private void resume(String key) {
       Deque<Runnable> tasks;
       synchronized (tasksByKey) {
         tasks = tasksByKey.get(key);
@@ -222,19 +216,11 @@ void resume(final String key) {
           return;
         }
       }
-      final Deque<Runnable> finalTasks = tasks;
-      // Run the next task.
-      executor.execute(
-          new Runnable() {
-            @Override
-            public void run() {
-              invokeCallback(finalTasks);
-            }
-          });
+      execute(key, tasks);
     }
 
     /** Cancels every task in the queue assoicated with {@code key}. */
-    void cancelQueuedTasks(final String key, Throwable e) {
+    private void cancelQueuedTasks(final String key, Throwable e) {
       // TODO(kimkyung-goog): Ensure execute() fails once cancelQueueTasks() has been ever invoked,
       // so that no more tasks are scheduled.
       synchronized (tasksByKey) {
